ci: add Windows x64 wheels#47
Merged
Merged
Conversation
Closed
Collaborator
|
Excellent! I'll get a Windows machine to test this on. |
bbayles
approved these changes
Oct 30, 2023
Collaborator
bbayles
left a comment
bbayles
left a comment
There was a problem hiding this comment.
Great work on this - many thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also aim to fix #24.
Thanks @plusiv for #46 (comment), where he came up with the solution.
It's a little bit tricky: maybe
makecannot work withvcvars64.batto modify the env, so I use a longbefore-build.And I don't know how to choose from
vcvars64.batandvcvars32.batby the OS arch. So only x64 wheels are available.Some questions:
.o,.cpp,.c,.hfiles in the wheels? Afaik, ada works well without them.pip install ada_url --no-binary ada_urlwill fail (on both Linux and Windows) because of the absence ofada.o, same as Feat: add windows wheels #46 (comment). Maybe we can open a new issue for this?Microsoft Visual C++ 2015-2022 Redistributable is needed at runtime.