Add Maven configuration warm-path benchmark - #9
Conversation
Move the Maven configuration warm-path benchmark into the benchmarks repository with a configurable setup-java repository and refs, local helper script, and README coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9187715c-3092-4f20-b10a-070980b669e7
There was a problem hiding this comment.
🟡 Not ready to approve
The new workflow executes a user-specified repository as an action, so the workflow_dispatch input should clearly indicate it must reference a trusted repo to avoid accidental execution of untrusted code.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR adds a new GitHub Actions benchmark workflow to measure the warm-path performance of actions/setup-java’s Maven configuration logic across multiple OS/cache/toolchain scenarios, along with a helper script to record timings and bundle-size metrics and documentation describing the workflow.
Changes:
- Added
scripts/benchmark-maven-configuration.shto prepare fixtures, record setup timings, recorddist/setupsize metrics, and write a Markdown summary. - Added
.github/workflows/maven-configuration-warm-path.ymlto run baseline vs candidatesetup-javarefs across a matrix of OS/cache/version/toolchains combinations. - Updated
README.mdto document the new benchmark workflow and recommend basic script linting commands.
File summaries
| File | Description |
|---|---|
| scripts/benchmark-maven-configuration.sh | Adds benchmark helper for timing, size recording, and summary generation. |
| .github/workflows/maven-configuration-warm-path.yml | Introduces the dispatchable benchmark workflow comparing two setup-java refs across a matrix. |
| README.md | Documents the new workflow and adds script validation commands. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Low
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| setup-java-repository: | ||
| description: Repository containing the setup-java action | ||
| required: true | ||
| default: actions/setup-java | ||
| type: string |
Summary
Validation