Skip to content

fix(task): reset isStreaming in abortTask to prevent UI lock after task switch (fixes #257) #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
proyectoauraorg wants to merge 7 commits into from
Closed

fix(task): reset isStreaming in abortTask to prevent UI lock after task switch (fixes #257) #388

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
86c40cd
test(mimo): add completePrompt and advanced streaming tests for Mimo …
proyectoauraorg May 26, 2026
24aec68
chore(deps): bump uuid from 11.1.0 to 14.0.0
dependabot[bot] May 26, 2026
82bd057
Merge remote-tracking branch 'upstream/main'
proyectoauraorg May 29, 2026
48ea5d4
fix(task): reset isStreaming state in abortTask to prevent UI lock af…
proyectoauraorg May 29, 2026
816121f
chore: pin uuid to ^11.1.0 and remove stray tmp/README.md
proyectoauraorg May 29, 2026
790b55d
chore: remove unrelated Mimo provider test (leaked from a shared base)
proyectoauraorg May 29, 2026
e21e53b
test: restore mimo.spec.ts to match main (revert unintended removal)
proyectoauraorg May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/core/task/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2118,6 +2118,13 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {

this.abort = true

// Reset streaming state so the UI unlocks immediately.
// Without this, task switches that call abortTask() without going
// through resumeAfterDelegation() leave isStreaming=true, causing
// the chat input to remain locked (issue #257).
this.isStreaming = false

@edelauna edelauna Jun 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we preserve the previous streaming state for cleanup before flipping this? dispose() still uses this.isStreaming && this.diffViewProvider.isEditing to revert active diff edits, and cancelTask() treats isStreaming === false as the signal to rehydrate, so clearing it synchronously here may skip cleanup or race the abort save.

this.isWaitingForFirstChunk = false

// Reset consecutive error counters on abort (manual intervention)
this.consecutiveNoToolUseCount = 0
this.consecutiveNoAssistantMessagesCount = 0
Expand Down
Loading