perf(write-path): remove artificial write delays by default (part of #1375) by easonLiangWorldedtech · Pull Request #1381 · Zoo-Code-Org/Zoo-Code

easonLiangWorldedtech · 2026-08-27T01:42:08Z

Tracking issue: #1386

Summary

Speed follow-through on epic #1375: removes the two artificial latency sources on the agent file-write path.

Changes

DEFAULT_WRITE_DELAY_MS: 1000 → 0 (packages/types/src/global-settings.ts)

Every write (write_to_file, edit_file, edit, search_replace, apply_patch, apply_diff, and the DiffViewProvider save paths) waited a full second after saving, before reporting diagnostics. With the default now 0 the write path adds no artificial pacing.

The setting itself is unchanged and still round-trips through storage/UI; users who rely on auto-formatters that settle asynchronously (e.g. goimports for Go) can raise writeDelayMs back up. The constant's doc comment now documents that tradeoff.
All consumers already read state?.writeDelayMs ?? DEFAULT_WRITE_DELAY_MS, so the one-line default change is sufficient.

Removed delay(300) before scrollToFirstDiff() (src/core/tools/WriteToFileTool.ts)

The other five write tools already call scrollToFirstDiff() without a preceding delay, and DiffViewProvider.scrollToFirstDiff() already re-reveals the first diff on a deferred 100 ms timer specifically to beat the diff editor's late layout pass — the 300 ms pause was redundant. The now-unused delay import was removed (DiffViewProvider still imports the package).

Tests

ClineProvider.spec.ts asserted the old default literally (toBe(1000)); it now asserts DEFAULT_WRITE_DELAY_MS.
pnpm --dir src exec vitest run core/webview/__tests__/ClineProvider.spec.ts core/tools/__tests__/WriteToFileTool.spec.ts → 151 + 19 passing.
ESLint clean on all touched files; no suppression count changes.

Tradeoff note

For languages where a post-save auto-formatter takes time to settle (Go/goimports is the documented case), the diagnostic window captured after a write is now 0 ms by default. That is the intended speed/safety tradeoff per #1375; the setting remains available for users who need the old behavior.

This is an auto-generated comment: release notes by coderabbit.ai -->

Summary by CodeRabbit

Performance
- File writes and diagnostics now appear faster by default.
- Diff views no longer pause before navigating to the first change.
Configuration
- The default write delay is now 0 milliseconds.
- A custom delay remains available for formatters that need additional settling time before diagnostics are collected.

end of auto-generated comment: release notes by coderabbit.ai -->

Update (CodeRabbit-sync from trial #1413): head `654801346` — webview createInitialExtensionState now uses the shared DEFAULT_WRITE_DELAY_MS (instead of a hard-coded 1000 placeholder) + focused pre-hydration test (trial addenda `178e6f4` + `4fc14c4`). Review context: trial PR #1413.

Review-gate re-trigger (2026-08-30): empty commit `309ffd6` (no code change) re-runs CI and CodeRabbit current-head review under the org new PR review gate; the code head remains `6548013`.

Review feedback (2026-09-04 CodeRabbit cycle): abb8a21 replaces the any cast in the writeDelayMs default test with a typed vi.fn reassignment (the same pattern the customModePrompts test in that file already uses — Memento.get has no mock type) — behavior is unchanged and the file's no-explicit-any suppression count drops by one (198 → 197).

Mutation gate: the branch now contains current upstream/main — the head commit is a merge with current main (7328cbf) as its first parent, the same shape as the CI job's synthetic merge commit. The gate's resolvePullRequestBase resolves a merge-commit head to its first parent, and this branch's last main sync (0d937c0) predates the gate rewrite, so without this merge every CI run would measure the true PR delta plus every main commit since. The true delta's executable changes are: one line in webview-ui/src/context/ExtensionStateContext.tsx (writeDelayMs: 1000 → writeDelayMs: DEFAULT_WRITE_DELAY_MS — a bare identifier, which the default Stryker mutator set does not touch), two pure deletions in src/core/tools/WriteToFileTool.ts (no head-side executable lines), and DEFAULT_WRITE_DELAY_MS (1000 → 0) in packages/types/src/global-settings.ts — the types package is outside the gate's package set. So the delta carries no mutation target and the gate passes trivially; the local preflight below certifies exactly that:

Local preflight on the true delta (7328cbf → 1ff2d59): exit 0 — the webview package was selected (5 changed executable lines), Stryker's dry run reported Instrumented 1 source file(s) with 0 mutant(s), and the gate took its designed "No mutants generated" short-circuit (digest: pass true, stale false, no reports — nothing could survive).

…oo-Code-Org#1375) Two latency sources on the agent file-write path were removed or defaulted off: - DEFAULT_WRITE_DELAY_MS is now 0 instead of 1000, so writes no longer wait a full second for post-save diagnostics by default. The setting itself is unchanged: users who rely on auto-formatters that settle asynchronously (e.g. goimports for Go) can raise writeDelayMs back up; the comment on the constant documents that tradeoff. - WriteToFileTool no longer waits delay(300) before scrollToFirstDiff(). The other five write tools (EditFile, Edit, SearchReplace, ApplyPatch, ApplyDiff) already call scrollToFirstDiff() directly, and DiffViewProvider already re-reveals the first diff on a deferred 100ms timer to beat the diff editor's late layout pass, so the 300ms pause was redundant pacing. The delay() import is removed (DiffViewProvider still uses the package). Tests: ClineProvider spec now asserts the default via DEFAULT_WRITE_DELAY_MS instead of a hardcoded 1000. WriteToFileTool and ClineProvider suites pass (19 + 151).

coderabbitai · 2026-08-27T01:43:25Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: Zoo-Code-Org/Zoo-Code/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: e0176c67-a7b5-48fb-ae5d-772846b5c6be

📥 Commits

Reviewing files that changed from the base of the PR and between a704002 and e5d4a77.

📒 Files selected for processing (7)

packages/types/src/global-settings.ts
src/core/tools/WriteToFileTool.ts
src/core/webview/__tests__/ClineProvider.spec.ts
src/eslint-suppressions.json
src/integrations/editor/__tests__/DiffViewProvider.spec.ts
webview-ui/src/context/ExtensionStateContext.tsx
webview-ui/src/context/__tests__/ExtensionStateContext.spec.tsx

💤 Files with no reviewable changes (1)

src/core/tools/WriteToFileTool.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

📜 Recent review details

🧰 Additional context used

📓 Path-based instructions (6)

For persisted settings, verify the complete schema/storage/runtime/webview round trip, shared default semantics, and focused true plus false/unset tests.