You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[lifecycle-RSK] RSK-07: Flip abort and abortReason reads #1797
Design doc: docs/architecture/task-lifecycle-target-architecture.md (not yet on main)
Ticket plan: docs/architecture/task-lifecycle-run-state-kernel-tickets.md (not yet on main)
Context
With writes routed and the comparison clean, these reads move to the latch getters. abort must stay true after the stream ends and after disposal. The run loop is while (!this.abort) (Task.ts:2953), and guards read it after the abort (TaskScheduler.ts:34, TaskRegistry.ts:67, 73, ClineProvider.ts:4388, presentAssistantMessage.ts:88, Task.ts:1654).
Developer Notes
Precondition: the comparison shows zero untagged divergence and zero untagged rejections for latch events on nightly.
Add getters that read latches.abort and latches.reason.
Flip the 41 abort reads and the 4 abortReason reads.
Delete the two fields and remove their writes from the helpers.
Exit criteria: no direct reads remain. Tests and E2E pass. The run loop and the latched guards still work.
Reversibility: revert this PR. The helpers restore the fields.
Activity