Skip to content

Add TypeScript checking and fix TS issues in wp-tooltip.js#12546

Closed
westonruter wants to merge 2 commits into
WordPress:trunkfrom
westonruter:add/wp-tooltip-typescript
Closed

Add TypeScript checking and fix TS issues in wp-tooltip.js#12546
westonruter wants to merge 2 commits into
WordPress:trunkfrom
westonruter:add/wp-tooltip-typescript

Conversation

@westonruter

@westonruter westonruter commented Jul 15, 2026

Copy link
Copy Markdown
Member

✅ Committed in r62794 (07a2d76)


This is a follow-up to r62741.

Trac ticket: https://core.trac.wordpress.org/ticket/51006

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 4.8
Used for: Debugging and reviewing.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@westonruter
westonruter requested review from desrosj and removed request for desrosj July 15, 2026 18:10
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter
westonruter requested a review from joedolson July 15, 2026 18:10
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@joedolson joedolson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

pento pushed a commit that referenced this pull request Jul 18, 2026
…tip.js`.

The `files` in `tsconfig.json` are also re-sorted.

Developed in #12546.
Follow-up to r62741.

Props westonruter, joedolson.
See #51006.


git-svn-id: https://develop.svn.wordpress.org/trunk@62794 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Jul 18, 2026
…tip.js`.

The `files` in `tsconfig.json` are also re-sorted.

Developed in WordPress/wordpress-develop#12546.
Follow-up to r62741.

Props westonruter, joedolson.
See #51006.

Built from https://develop.svn.wordpress.org/trunk@62794


git-svn-id: http://core.svn.wordpress.org/trunk@62074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants