Conversation
`StepRunner` only awaited the step body when its "type" argument was "async". `AsyncBenchmarkStep` created an `AsyncStepRunner` without passing that argument, so the step promise was never awaited and an async remote step measured ~0ms with no error. This commit makes the runner class decide instead: an `isAsync` getter is false on `StepRunner` and true on `AsyncStepRunner`, and the type argument is removed. Sync steps stay a plain call, since awaiting them would add a microtask hop to the measured time. The bug was never hit because nothing in the tree or in the open workload PRs uses `AsyncBenchmarkStep`. But this is a requirement for the pdf.js workload that I'm working on.
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StepRunneronly awaited the step body when its "type" argument was "async".AsyncBenchmarkStepcreated anAsyncStepRunnerwithout passing that argument, so the step promise was never awaited and an async remote step measured ~0ms with no error.This commit makes the runner class decide instead: an
isAsyncgetter is false onStepRunnerand true onAsyncStepRunner, and the type argument is removed. Sync steps stay a plain call, since awaiting them would add a microtask hop to the measured time.The bug was never hit because nothing in the tree or in the open workload PRs uses
AsyncBenchmarkStep. But this is a requirement for the pdf.js workload that I'm working on.