mingw build: alias CMSG_LEN like the other cmsg accessors - #423
Open
tycho wants to merge 1 commit into
Open
Conversation
The MinGW compatibility block maps cmsghdr, CMSG_FIRSTHDR, and CMSG_NXTHDR (and, just below, CMSG_DATA) to their WSA_-prefixed forms, but not CMSG_LEN. MSVC builds work regardless because its ws2def.h happens to define the unprefixed CMSG_LEN; mingw-w64's headers only provide WSA_CMSG_LEN, so the IP_TOS / IPV6_TCLASS cmsg_len checks in the recvmsg path fail to compile: error: 'CMSG_LEN' was not declared in this scope Alias it alongside the others. Signed-off-by: Steven Noonan <steven@uplinklabs.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MinGW compatibility block maps cmsghdr, CMSG_FIRSTHDR, and CMSG_NXTHDR (and, just below, CMSG_DATA) to their WSA_-prefixed forms, but not CMSG_LEN. MSVC builds work regardless because its ws2def.h happens to define the unprefixed CMSG_LEN; mingw-w64's headers only provide WSA_CMSG_LEN, so the IP_TOS / IPV6_TCLASS cmsg_len checks in the recvmsg path fail to compile:
Alias it alongside the others.