Skip to content

fix: dynamic prefabs loaded status correctly shown on host #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fernando-cortez merged 2 commits into from
Mar 6, 2023
Merged

fix: dynamic prefabs loaded status correctly shown on host #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9d5676
loaded status shown correctly on host
fernando-cortez Mar 2, 2023
23206f1
changelog update
fernando-cortez Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../Assets/Scripts/02_Server Authoritative Load All Async/ServerAuthoritativeLoadAllAsync.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ async Task PreloadDynamicPrefabOnServerAndStartLoadingOnAllClients(string guid)
m_InGameUI.ClientLoadedPrefabStatusChanged(client,
assetGuid.GetHashCode(),
loadedGameObject.Result.name,
InGameUI.LoadStatus.Loading);
InGameUI.LoadStatus.Loaded);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...ts/03_Server Authoritative Synchronous Spawning/ServerAuthoritativeSynchronousSpawning.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ NetworkObject Spawn(AddressableGUID assetGuid)
m_InGameUI.ClientLoadedPrefabStatusChanged(client,
assetGuid.GetHashCode(),
prefab.Result.name,
InGameUI.LoadStatus.Loading);
InGameUI.LoadStatus.Loaded);
}

return obj;
Expand Down
2 changes: 1 addition & 1 deletion Basic/DynamicAddressablesNetworkPrefabs/Assets/Scripts/05_API Playground/APIPlayground.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ async Task PreloadDynamicPrefabOnServerAndStartLoadingOnAllClients(string guid)
m_InGameUI.ClientLoadedPrefabStatusChanged(client,
assetGuid.GetHashCode(),
loadedGameObject.Result.name,
InGameUI.LoadStatus.Loading);
InGameUI.LoadStatus.Loaded);
}
}
}
Expand Down
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
# Change log

## [unreleased] - yyyy-mm-dd
N/A

### Dynamic Addressables Network Prefabs

#### Fixed
- Resolved visual bug where the load status of dynamic prefabs on the host was not correct (#111)

## [1.2.1] - 2023-02-17

Expand Down