Switch to kts - #976
Merged
Merged
Switch to kts#976
Conversation
denis-fokin
requested review from
Markoutte,
dtim,
mmvpm and
viktoriia-fomina
September 20, 2022 08:33
denis-fokin
force-pushed
the
denis-fokin/switch-master-to-kts
branch
from
September 20, 2022 09:14
7f34943 to
c7ee388
Compare
denis-fokin
marked this pull request as draft
September 20, 2022 09:31
denis-fokin
force-pushed
the
denis-fokin/switch-master-to-kts
branch
4 times, most recently
from
September 20, 2022 13:57
dcd770e to
9a806f5
Compare
denis-fokin
marked this pull request as ready for review
September 20, 2022 14:14
denis-fokin
enabled auto-merge (squash)
September 20, 2022 14:27
dtim
requested changes
Sep 20, 2022
dtim
left a comment
dtim
left a comment
Collaborator
There was a problem hiding this comment.
Please fix the Kotlin languageVersion and apiVersion, they may have unintended effects on building process and IDE behavior. Other comments are related to improvements.
denis-fokin
force-pushed
the
denis-fokin/switch-master-to-kts
branch
from
September 20, 2022 15:46
792afed to
fbc916b
Compare
mmvpm
requested changes
Sep 21, 2022
denis-fokin
force-pushed
the
denis-fokin/switch-master-to-kts
branch
from
September 21, 2022 08:38
fbc916b to
f411983
Compare
denis-fokin
disabled auto-merge
September 21, 2022 08:48
mmvpm
reviewed
Sep 21, 2022
denis-fokin
force-pushed
the
denis-fokin/switch-master-to-kts
branch
2 times, most recently
from
September 21, 2022 12:19
b18fded to
c07c637
Compare
mmvpm
approved these changes
Sep 21, 2022
Markoutte
reviewed
Sep 21, 2022
Markoutte
reviewed
Sep 21, 2022
denis-fokin
force-pushed
the
denis-fokin/switch-master-to-kts
branch
from
September 22, 2022 06:25
c07c637 to
6ed18f5
Compare
denis-fokin
force-pushed
the
denis-fokin/switch-master-to-kts
branch
from
September 22, 2022 08:02
6ed18f5 to
cd81dd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scripts important for multi-language support are switched to kts
Fixes #975
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Automated Testing
CI
Manual Scenario
No specific manual scenario.
Checklist (remove irrelevant options):