fix(ui5-multi-combobox): announce suggestions selected state#13767
Merged
Conversation
aleksandar-terziev
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
|
🚀 Deployed on https://pr-13767--ui5-webcomponents-preview.netlify.app |
yanaminkova
previously approved these changes
Jul 3, 2026
yanaminkova
left a comment
yanaminkova
left a comment
Contributor
There was a problem hiding this comment.
Approved from the List side
nikoletavnv
requested changes
Jul 6, 2026
nikoletavnv
left a comment
nikoletavnv
left a comment
Contributor
There was a problem hiding this comment.
When navigating through the mcb items using the Arrow keys, I always have an announcement stating "Not selected " even when the item is visually selected and checked. The shadow list element has properly set aria-selected but it does affect the announcement on focus.
aleksandar-terziev
force-pushed
the
mcb-selected-state-announcement
branch
from
953c24e to
73fb8ce
Compare
aleksandar-terziev
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
aleksandar-terziev
force-pushed
the
mcb-selected-state-announcement
branch
from
73fb8ce to
ac3c0d5
Compare
aleksandar-terziev
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
aleksandar-terziev
force-pushed
the
mcb-selected-state-announcement
branch
from
ac3c0d5 to
50c00e3
Compare
aleksandar-terziev
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
nikoletavnv
approved these changes
Jul 9, 2026
|
🧹 Preview deployment cleaned up: https://pr-13767--ui5-webcomponents.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13225
Fixes: #13579
Added Invisible Message
ui5-hidden-textto announce the selected state ("Selected," / "Not Selected,") for MultiComboBox items.Latest versions of JAWS and NVDA does not correctly read
aria-selectedattributes inside Shadow DOM. Therefore the initial approach witharia-multiselectableandaria-selecteddoes not resolve the issue.