Repository navigation
Conversation
d3xter666
marked this pull request as draft
October 8, 2026 06:28
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Keep in mind that there will be CodeQL security advisories here. It's just for testing purposes
d3xter666
force-pushed
the
refactor-security-audit
branch
2 times, most recently
from
October 12, 2026 12:42
098fb4d to
408ae9f
Compare
Replace the monolithic audit.sh with single-responsibility Node ESM scripts (zero runtime deps): audit-repo and audit-npm (never fail), format-github/format-cli, gate, and an audit-all driver, with a shared targets.json. Audit both source repositories and published npm packages, reported in separate tables. Add parallel matrix GitHub workflows (reusable engine + scheduled + manual) with an always-present summary job, and a Jenkinsfile that reuses the same scripts.
d3xter666
force-pushed
the
refactor-security-audit
branch
from
October 12, 2026 14:15
408ae9f to
d8cdf22
Compare
Member
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why audit three ways, not one
The workflow runs the audit from three angles, to separate what we tested from what users get from our full dev surface:
Reworks the dependency audit into a small, reusable toolchain (zero-dependency Node scripts behind
audit-ci) that can run from GitHub Actions and Jenkins alike.npm cipackage-lock.jsonpins — the reproducible tree we build & test against.npm install,--skip-dev@ui5/cliinstall gives users today. The one that matters most.npm installnpm installover an empty project with@ui5/*package as dependencyFindings are rendered as separate tables in the job summary; a gate step then fails the build on any finding.
How the audit can run (three ways, one shared engine)
targets.json(UI5 CLI v4/v5, UI5 linter, UI5 MCP server) out into a parallel matrix job each, with an always-present summary job that merges results.selfcomposite action to audit its own source + its own published package; no audit logic is copied.Jenkinsfilemirrors the central run, reusing the exact same scripts with a plain-text (CLI) formatter.