Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions examples/01-basic/01-minimal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"private": true,
"version": "0.12.4",
"scripts": {
"start": "vp dev",
"dev": "vp dev",
"build:prod": "tsc && vp build",
"preview": "vp preview"
"start": "vite",
"dev": "vite",
"build:prod": "tsc && vite build",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Remove direct tsc usage from the standalone build scripts.

The four generated package manifests use tsc for type-checking. The repository guideline requires vp run lint and prohibits direct tsc usage.

  • examples/01-basic/01-minimal/package.json#L10-L10: change the script to vite build.
  • examples/01-basic/02-block-objects/package.json#L10-L10: change the script to vite build.
  • examples/04-theming/03-theming-css/package.json#L10-L10: change the script to vite build.
  • examples/04-theming/04-theming-css-variables/package.json#L10-L10: change the script to vite build.

As per coding guidelines, use vp run lint for linting and type-checking; do not use tsc or prettier.

📍 Affects 4 files
  • examples/01-basic/01-minimal/package.json#L10-L10 (this comment)
  • examples/01-basic/02-block-objects/package.json#L10-L10
  • examples/04-theming/03-theming-css/package.json#L10-L10
  • examples/04-theming/04-theming-css-variables/package.json#L10-L10
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/01-basic/01-minimal/package.json` at line 10, Replace the build:prod
script with vite build in examples/01-basic/01-minimal/package.json (line 10),
examples/01-basic/02-block-objects/package.json (line 10),
examples/04-theming/03-theming-css/package.json (line 10), and
examples/04-theming/04-theming-css-variables/package.json (line 10), removing
direct tsc usage from all four manifests. Use vp run lint for linting and
type-checking instead of tsc or prettier.

Source: Coding guidelines

"preview": "vite preview"
},
"dependencies": {
"@blocknote/ariakit": "latest",
Expand All @@ -25,6 +25,6 @@
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.1",
"vite-plus": "^0.1.24"
"vite": "^8.0.0"
}
}
2 changes: 1 addition & 1 deletion examples/01-basic/01-minimal/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/// <reference types="vite-plus/client" />
/// <reference types="vite/client" />
2 changes: 1 addition & 1 deletion examples/01-basic/01-minimal/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import react from "@vitejs/plugin-react";
import * as fs from "fs";
import * as path from "path";
import { defineConfig } from "vite-plus";
import { defineConfig } from "vite";
// https://vitejs.dev/config/
export default defineConfig(((conf: { command: string }) => ({
plugins: [react()],
Expand Down
10 changes: 5 additions & 5 deletions examples/01-basic/02-block-objects/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"private": true,
"version": "0.12.4",
"scripts": {
"start": "vp dev",
"dev": "vp dev",
"build:prod": "tsc && vp build",
"preview": "vp preview"
"start": "vite",
"dev": "vite",
"build:prod": "tsc && vite build",
"preview": "vite preview"
},
"dependencies": {
"@blocknote/ariakit": "latest",
Expand All @@ -25,6 +25,6 @@
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.1",
"vite-plus": "^0.1.24"
"vite": "^8.0.0"
}
}
2 changes: 1 addition & 1 deletion examples/01-basic/02-block-objects/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/// <reference types="vite-plus/client" />
/// <reference types="vite/client" />
2 changes: 1 addition & 1 deletion examples/01-basic/02-block-objects/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import react from "@vitejs/plugin-react";
import * as fs from "fs";
import * as path from "path";
import { defineConfig } from "vite-plus";
import { defineConfig } from "vite";
// https://vitejs.dev/config/
export default defineConfig(((conf: { command: string }) => ({
plugins: [react()],
Expand Down
10 changes: 5 additions & 5 deletions examples/01-basic/03-multi-column/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"private": true,
"version": "0.12.4",
"scripts": {
"start": "vp dev",
"dev": "vp dev",
"build:prod": "tsc && vp build",
"preview": "vp preview"
"start": "vite",
"dev": "vite",
"build:prod": "tsc && vite build",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -eu

printf '%s\n' '--- target package scripts ---'
for f in \
  examples/01-basic/03-multi-column/package.json \
  examples/04-theming/05-theming-css-variables-code/package.json \
  examples/04-theming/06-code-block/package.json \
  examples/04-theming/07-custom-code-block/package.json
do
  printf '\n### %s\n' "$f"
  cat -n "$f"
done

printf '%s\n' '--- repository command and migration context ---'
printf '\n### package-manager files\n'
git ls-files | rg '(^|/)(package.json|pnpm-lock.yaml|pnpm-workspace.yaml|vp|stackblitz|README|CONTRIBUTING|AGENTS\.md)$' || true
printf '\n### direct tsc/build:prod occurrences\n'
rg -n --glob 'package.json' '"build:prod"|(^|[^[:alnum:]_])tsc([^[:alnum:]_]|$)|vp run lint|pnpm' . || true
printf '\n### root package scripts/configuration\n'
if [ -f package.json ]; then cat -n package.json; fi
if [ -f pnpm-workspace.yaml ]; then cat -n pnpm-workspace.yaml; fi

Repository: TypeCellOS/BlockNote

Length of output: 2114


🌐 Web query:

TypeCellOS/BlockNote examples/01-basic/03-multi-column/package.json build:prod tsc vp run lint

💡 Result:

The command build:prod tsc vp run lint appears to be a reference to build and quality-assurance orchestration within the TypeCellOS/BlockNote monorepo. In the context of the BlockNote project: 1. build:prod: This is a script typically used to trigger a production build of the project [1][2]. 2. tsc: Historically, this was used for TypeScript type declaration emitting [3][4]. However, recent updates to the repository have migrated type declaration processes from tsc to tsgo to improve performance [3][4]. 3. vp: This refers to the build orchestration and task execution system (often utilizing Nx) used within the monorepo [3][1][2]. Commands like vp run lint or vp run build are used to execute specific tasks across the monorepo's packages, supporting parallel execution and distributed caching [1][2]. 4. run lint: This invokes the linting process (using tools like ESLint and oxlint) to enforce code quality across the codebase [3][1][2]. The specific example mentioned, examples/01-basic/03-multi-column, is part of the BlockNote documentation and playground examples [5][6][7]. It demonstrates the usage of multi-column blocks, which are implemented via the @blocknote/xl-multi-column package [6][7]. As of August 2026, the build pipeline for BlockNote is highly optimized, utilizing Nx for task orchestration and having recently transitioned to tsgo for faster type checking [3][1][4].

Citations:


🌐 Web query:

TypeCellOS/BlockNote examples/04-theming/05-theming-css-variables-code/package.json

💡 Result:

The package.json file for the BlockNote example located at examples/04-theming/05-theming-css-variables-code is part of the official TypeCellOS/BlockNote repository [1][2]. This example demonstrates how to override BlockNote's default theme CSS variables [3][4]. As of the current project structure, this directory contains a standard package.json file configured for a React-based project, which has been updated to use the Vite build tool [5][6]. The file defines the necessary dependencies and scripts required to run the example, typically including react, react-dom, and the @blocknote/react and @blocknote/core packages, along with build and development scripts like dev, build, and preview [5][7]. Because the repository is managed using a monorepo structure (utilizing tools like pnpm and Nx), the package.json files in example directories are generally lightweight and rely on the workspace's root configuration for shared dependencies and build settings [8]. You can view the exact contents of this file by navigating to the official TypeCellOS/BlockNote repository on GitHub [2].

Citations:


🏁 Script executed:

#!/bin/bash
set -eu

base='https://raw.githubusercontent.com/TypeCellOS/BlockNote/main'
files=(
  'examples/01-basic/03-multi-column/package.json'
  'examples/04-theming/05-theming-css-variables-code/package.json'
  'examples/04-theming/06-code-block/package.json'
  'examples/04-theming/07-custom-code-block/package.json'
  'package.json'
  'pnpm-workspace.yaml'
)

for path in "${files[@]}"; do
  printf '\n### %s\n' "$path"
  curl -fsSL "$base/$path" | nl -ba
done

printf '\n### matching package scripts in the current public tree\n'
curl -fsSL 'https://api.github.com/repos/TypeCellOS/BlockNote/git/trees/main?recursive=1' |
  jq -r '.tree[] | select(.path | endswith("package.json")) | .path' |
  while IFS= read -r path; do
    content=$(curl -fsSL "$base/$path" 2>/dev/null || true)
    if printf '%s' "$content" | grep -Eq '"build:prod"|(^|[^[:alnum:]_])tsc([^[:alnum:]_]|$)|vp run lint'; then
      printf '%s\n' "$path"
      printf '%s\n' "$content" | jq -r '.scripts // {} | to_entries[] | "\(.key)=\(.value)"' 2>/dev/null || true
    fi
  done

Repository: TypeCellOS/BlockNote

Length of output: 2114


🌐 Web query:

site:github.com/TypeCellOS/BlockNote "examples/01-basic/03-multi-column/package.json" "\"build:prod\""

💡 Result:

In the BlockNote project repository, the build:prod script in various package.json files—including examples/01-basic/03-multi-column/package.json—was removed as part of a migration to Vite+ [1]. Previously, these files contained build scripts (such as build:prod) to manage project builds. However, following the migration to the Vite+ build system, these scripts were moved to tasks defined within the corresponding vite.config.ts files [1]. This change was implemented to improve cache management and avoid overly broad input tracking [1]. If you are looking for how to build these projects in the current repository structure, you should check the tasks defined in the vite.config.ts file for the specific package or example, or use the centralized build commands provided by the project's updated tooling [1][2].

Citations:


🌐 Web query:

site:github.com/TypeCellOS/BlockNote "examples/04-theming/06-code-block/package.json" "\"build:prod\""

💡 Result:

The file examples/04-theming/06-code-block/package.json is part of the BlockNote repository [1][2]. In the context of this project, build scripts like "build:prod" are typically defined within package.json files to facilitate the compilation of examples or packages using tools like Vite [3][4]. While the specific contents of "build:prod" can change as the project evolves [2][5], it generally serves as a production-optimized build command. In the BlockNote monorepo, which uses pnpm and Nx [2][6], these scripts often leverage vite build [7][4] to bundle the TypeScript/React code for production deployment. You can view the current definition of this script by navigating directly to the file in the TypeCellOS/BlockNote repository [1].

Citations:


🌐 Web query:

site:github.com/TypeCellOS/BlockNote "vp run lint" "StackBlitz"

💡 Result:

The command vp run lint is not a standard tool for StackBlitz, but rather a specific command used in projects utilizing the Vite+ (or Vite Task) build and task runner system [1][2]. In the context of the BlockNote repository and similar projects, vp is a task runner that integrates with Vite [1]. The command vp run lint triggers a configured linting task—often utilizing oxlint, which is a high-performance, Rust-based linter [1]. When you encounter or use this command: 1. Task Runner: The vp command is part of a custom workspace setup (often involving the voidzero-dev/setup-vp action in CI/CD pipelines) [3][1]. 2. Configuration: The tasks themselves, including lint, are defined within the project's configuration (usually vite.config.ts or associated task definitions) rather than standard package.json scripts [1]. 3. StackBlitz: If you are seeing this in a StackBlitz environment, it is because that specific project is configured to use the Vite+ task system [4]. If the command fails in your specific StackBlitz instance, it likely means the environment is not correctly configured to recognize the vp binary or the task graph is missing dependencies (e.g., needing a build step before linting, as is often the case with type-aware linting) [5][6]. To troubleshoot or run it correctly, ensure you have the necessary project dependencies installed and that the environment supports the Vite+ task runner [1][7].

Citations:


🌐 Web query:

GitHub TypeCellOS BlockNote pull 2745 examples 01-basic 03-multi-column package.json build:prod

💡 Result:

Pull request #2745 in the TypeCellOS/BlockNote repository marks the migration of the project's build system to Vite [1]. Regarding the specific items mentioned: 01-basic and 03-multi-column: These refer to directory paths within the BlockNote repository's example system [2]. Specifically, 01-basic is a category of examples focused on core features and setup, and 03-multi-column is a project within that category demonstrating multi-column block functionality (often utilizing the @blocknote/xl-multi-column package) [3][4][2]. package.json build:prod: Following the migration to Vite, the build:prod script in package.json is typically configured to execute the Vite production build command, often paired with TypeScript compilation (e.g., "tsc && vite build" or similar variations) to prepare the application for a production environment [5][6]. This is a standard pattern in modern React and TypeScript projects to ensure assets are optimized, minified, and compiled correctly [6].

Citations:


🌐 Web query:

GitHub TypeCellOS BlockNote pull 2745 examples 04-theming 05-theming-css-variables-code 06-code-block 07-custom-code-block package.json

💡 Result:

In the TypeCellOS BlockNote repository, pull request #2745 is a significant maintenance update that migrated the project to Vite [1][2]. The path components you mentioned refer to official example projects and documentation sections within the BlockNote ecosystem, specifically related to theming and code block customization: 04-theming: This directory contains examples for styling and customizing the BlockNote editor [3]. 05-theming-css-variables-code: This refers to an example demonstrating how to define and apply custom themes using code (i.e., passing a theme object to the BlockNoteView component) [4]. 06-code-block: This is the standard example for enabling and configuring code block syntax highlighting in the editor [5]. 07-custom-code-block: This example demonstrates how to configure advanced code block features, such as custom syntax highlighting themes and specific language support using the Shiki highlighter [6][3]. For any of these examples, the associated package.json file (located in the root of the respective example directory in the GitHub repository) manages the necessary dependencies (such as @blocknote/core, @blocknote/react, and @blocknote/mantine) required to run that specific feature demonstration. To implement these features in your own project, ensure you have the required BlockNote packages installed and that your schema is extended with the appropriate block specifications [6][5][7].

Citations:


🌐 Web query:

site:github.com/TypeCellOS/BlockNote "examples/04-theming/07-custom-code-block" "build:prod"

💡 Result:

The path examples/04-theming/07-custom-code-block refers to a specific example directory within the BlockNote repository (TypeCellOS/BlockNote) [1][2]. This example demonstrates how to implement and theme a custom code block in the BlockNote editor, specifically using the @blocknote/code-block package and Shiki for syntax highlighting [1][2]. Regarding the build:prod suffix mentioned in your query, it is not a standard part of the directory path itself, but rather a common command used to build projects in production mode (e.g., npm run build:prod or pnpm build:prod). In the context of the BlockNote project, this example covers: 1. Extending the editor's default schema to include a custom code block [1]. 2. Configuring code block highlighting themes and languages [1]. 3. Utilizing a Shiki highlighter bundle (often generated via a CLI tool) to manage syntax highlighting [1][2]. If you are attempting to build this specific example, ensure you are in the root or appropriate workspace directory of the BlockNote repository and use the package manager's build command as defined in the package.json file [2][3].

Citations:


Replace direct tsc invocations in all four build:prod scripts. Use vp run lint for type-checking before vite build. If StackBlitz does not provide vp, define and test an explicit exception.

📍 Affects 4 files
  • examples/01-basic/03-multi-column/package.json#L10-L10 (this comment)
  • examples/04-theming/05-theming-css-variables-code/package.json#L10-L10
  • examples/04-theming/06-code-block/package.json#L10-L10
  • examples/04-theming/07-custom-code-block/package.json#L10-L10
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/01-basic/03-multi-column/package.json` at line 10, Replace the
direct tsc invocation in the build:prod script of
examples/01-basic/03-multi-column/package.json,
examples/04-theming/05-theming-css-variables-code/package.json,
examples/04-theming/06-code-block/package.json, and
examples/04-theming/07-custom-code-block/package.json with vp run lint before
vite build. If StackBlitz lacks vp, define and test an explicit exception.

Source: Coding guidelines

"preview": "vite preview"
},
"dependencies": {
"@blocknote/ariakit": "latest",
Expand All @@ -26,6 +26,6 @@
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.1",
"vite-plus": "^0.1.24"
"vite": "^8.0.0"
}
}
2 changes: 1 addition & 1 deletion examples/01-basic/03-multi-column/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/// <reference types="vite-plus/client" />
/// <reference types="vite/client" />
2 changes: 1 addition & 1 deletion examples/01-basic/03-multi-column/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import react from "@vitejs/plugin-react";
import * as fs from "fs";
import * as path from "path";
import { defineConfig } from "vite-plus";
import { defineConfig } from "vite";
// https://vitejs.dev/config/
export default defineConfig(((conf: { command: string }) => ({
plugins: [react()],
Expand Down
10 changes: 5 additions & 5 deletions examples/01-basic/04-default-blocks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"private": true,
"version": "0.12.4",
"scripts": {
"start": "vp dev",
"dev": "vp dev",
"build:prod": "tsc && vp build",
"preview": "vp preview"
"start": "vite",
"dev": "vite",
"build:prod": "tsc && vite build",
"preview": "vite preview"
},
"dependencies": {
"@blocknote/ariakit": "latest",
Expand All @@ -25,6 +25,6 @@
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.1",
"vite-plus": "^0.1.24"
"vite": "^8.0.0"
}
}
2 changes: 1 addition & 1 deletion examples/01-basic/04-default-blocks/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/// <reference types="vite-plus/client" />
/// <reference types="vite/client" />
2 changes: 1 addition & 1 deletion examples/01-basic/04-default-blocks/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import react from "@vitejs/plugin-react";
import * as fs from "fs";
import * as path from "path";
import { defineConfig } from "vite-plus";
import { defineConfig } from "vite";
// https://vitejs.dev/config/
export default defineConfig(((conf: { command: string }) => ({
plugins: [react()],
Expand Down
10 changes: 5 additions & 5 deletions examples/01-basic/05-removing-default-blocks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"private": true,
"version": "0.12.4",
"scripts": {
"start": "vp dev",
"dev": "vp dev",
"build:prod": "tsc && vp build",
"preview": "vp preview"
"start": "vite",
"dev": "vite",
"build:prod": "tsc && vite build",
"preview": "vite preview"
},
"dependencies": {
"@blocknote/ariakit": "latest",
Expand All @@ -25,6 +25,6 @@
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.1",
"vite-plus": "^0.1.24"
"vite": "^8.0.0"
}
}
2 changes: 1 addition & 1 deletion examples/01-basic/05-removing-default-blocks/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/// <reference types="vite-plus/client" />
/// <reference types="vite/client" />
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import react from "@vitejs/plugin-react";
import * as fs from "fs";
import * as path from "path";
import { defineConfig } from "vite-plus";
import { defineConfig } from "vite";
// https://vitejs.dev/config/
export default defineConfig(((conf: { command: string }) => ({
plugins: [react()],
Expand Down
10 changes: 5 additions & 5 deletions examples/01-basic/06-block-manipulation/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"private": true,
"version": "0.12.4",
"scripts": {
"start": "vp dev",
"dev": "vp dev",
"build:prod": "tsc && vp build",
"preview": "vp preview"
"start": "vite",
"dev": "vite",
"build:prod": "tsc && vite build",
"preview": "vite preview"
},
"dependencies": {
"@blocknote/ariakit": "latest",
Expand All @@ -25,6 +25,6 @@
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.1",
"vite-plus": "^0.1.24"
"vite": "^8.0.0"
}
}
2 changes: 1 addition & 1 deletion examples/01-basic/06-block-manipulation/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/// <reference types="vite-plus/client" />
/// <reference types="vite/client" />
2 changes: 1 addition & 1 deletion examples/01-basic/06-block-manipulation/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import react from "@vitejs/plugin-react";
import * as fs from "fs";
import * as path from "path";
import { defineConfig } from "vite-plus";
import { defineConfig } from "vite";
// https://vitejs.dev/config/
export default defineConfig(((conf: { command: string }) => ({
plugins: [react()],
Expand Down
10 changes: 5 additions & 5 deletions examples/01-basic/07-selection-blocks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"private": true,
"version": "0.12.4",
"scripts": {
"start": "vp dev",
"dev": "vp dev",
"build:prod": "tsc && vp build",
"preview": "vp preview"
"start": "vite",
"dev": "vite",
"build:prod": "tsc && vite build",
"preview": "vite preview"
},
"dependencies": {
"@blocknote/ariakit": "latest",
Expand All @@ -25,6 +25,6 @@
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.1",
"vite-plus": "^0.1.24"
"vite": "^8.0.0"
}
}
2 changes: 1 addition & 1 deletion examples/01-basic/07-selection-blocks/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/// <reference types="vite-plus/client" />
/// <reference types="vite/client" />
2 changes: 1 addition & 1 deletion examples/01-basic/07-selection-blocks/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import react from "@vitejs/plugin-react";
import * as fs from "fs";
import * as path from "path";
import { defineConfig } from "vite-plus";
import { defineConfig } from "vite";
// https://vitejs.dev/config/
export default defineConfig(((conf: { command: string }) => ({
plugins: [react()],
Expand Down
10 changes: 5 additions & 5 deletions examples/01-basic/08-ariakit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"private": true,
"version": "0.12.4",
"scripts": {
"start": "vp dev",
"dev": "vp dev",
"build:prod": "tsc && vp build",
"preview": "vp preview"
"start": "vite",
"dev": "vite",
"build:prod": "tsc && vite build",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Use the prescribed type-check command consistently.

The four standalone package scripts invoke tsc directly. Replace it with vp run lint, or document an explicit exception for standalone examples.

  • examples/01-basic/08-ariakit/package.json#L10-L10: Update build:prod.
  • examples/05-interoperability/05-converting-blocks-to-pdf/package.json#L10-L10: Update build:prod.
  • examples/05-interoperability/06-converting-blocks-to-docx/package.json#L10-L10: Update build:prod.
  • examples/05-interoperability/07-converting-blocks-to-odt/package.json#L10-L10: Update build:prod.

As per coding guidelines, **/* requires vp run lint for linting and type-checking and forbids tsc or prettier.

📍 Affects 4 files
  • examples/01-basic/08-ariakit/package.json#L10-L10 (this comment)
  • examples/05-interoperability/05-converting-blocks-to-pdf/package.json#L10-L10
  • examples/05-interoperability/06-converting-blocks-to-docx/package.json#L10-L10
  • examples/05-interoperability/07-converting-blocks-to-odt/package.json#L10-L10
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/01-basic/08-ariakit/package.json` at line 10, Replace the direct tsc
invocation in the build:prod script with vp run lint in
examples/01-basic/08-ariakit/package.json:10-10,
examples/05-interoperability/05-converting-blocks-to-pdf/package.json:10-10,
examples/05-interoperability/06-converting-blocks-to-docx/package.json:10-10,
and examples/05-interoperability/07-converting-blocks-to-odt/package.json:10-10,
preserving the existing Vite build step.

Source: Coding guidelines

"preview": "vite preview"
},
"dependencies": {
"@blocknote/ariakit": "latest",
Expand All @@ -25,6 +25,6 @@
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.1",
"vite-plus": "^0.1.24"
"vite": "^8.0.0"
}
}
2 changes: 1 addition & 1 deletion examples/01-basic/08-ariakit/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/// <reference types="vite-plus/client" />
/// <reference types="vite/client" />
2 changes: 1 addition & 1 deletion examples/01-basic/08-ariakit/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import react from "@vitejs/plugin-react";
import * as fs from "fs";
import * as path from "path";
import { defineConfig } from "vite-plus";
import { defineConfig } from "vite";
// https://vitejs.dev/config/
export default defineConfig(((conf: { command: string }) => ({
plugins: [react()],
Expand Down
10 changes: 5 additions & 5 deletions examples/01-basic/09-shadcn/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"private": true,
"version": "0.12.4",
"scripts": {
"start": "vp dev",
"dev": "vp dev",
"build:prod": "tsc && vp build",
"preview": "vp preview"
"start": "vite",
"dev": "vite",
"build:prod": "tsc && vite build",
"preview": "vite preview"
},
"dependencies": {
"@blocknote/ariakit": "latest",
Expand All @@ -28,6 +28,6 @@
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.1",
"vite-plus": "^0.1.24"
"vite": "^8.0.0"
}
}
2 changes: 1 addition & 1 deletion examples/01-basic/09-shadcn/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/// <reference types="vite-plus/client" />
/// <reference types="vite/client" />
2 changes: 1 addition & 1 deletion examples/01-basic/09-shadcn/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import react from "@vitejs/plugin-react";
import * as fs from "fs";
import * as path from "path";
import { defineConfig } from "vite-plus";
import { defineConfig } from "vite";
import tailwindcss from "@tailwindcss/vite";
// https://vitejs.dev/config/
export default defineConfig(((conf: { command: string }) => ({
Expand Down
10 changes: 5 additions & 5 deletions examples/01-basic/10-localization/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"private": true,
"version": "0.12.4",
"scripts": {
"start": "vp dev",
"dev": "vp dev",
"build:prod": "tsc && vp build",
"preview": "vp preview"
"start": "vite",
"dev": "vite",
"build:prod": "tsc && vite build",
"preview": "vite preview"
},
"dependencies": {
"@blocknote/ariakit": "latest",
Expand All @@ -25,6 +25,6 @@
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.1",
"vite-plus": "^0.1.24"
"vite": "^8.0.0"
}
}
2 changes: 1 addition & 1 deletion examples/01-basic/10-localization/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/// <reference types="vite-plus/client" />
/// <reference types="vite/client" />
2 changes: 1 addition & 1 deletion examples/01-basic/10-localization/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import react from "@vitejs/plugin-react";
import * as fs from "fs";
import * as path from "path";
import { defineConfig } from "vite-plus";
import { defineConfig } from "vite";
// https://vitejs.dev/config/
export default defineConfig(((conf: { command: string }) => ({
plugins: [react()],
Expand Down
10 changes: 5 additions & 5 deletions examples/01-basic/11-custom-placeholder/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"private": true,
"version": "0.12.4",
"scripts": {
"start": "vp dev",
"dev": "vp dev",
"build:prod": "tsc && vp build",
"preview": "vp preview"
"start": "vite",
"dev": "vite",
"build:prod": "tsc && vite build",
"preview": "vite preview"
},
"dependencies": {
"@blocknote/ariakit": "latest",
Expand All @@ -25,6 +25,6 @@
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^6.0.1",
"vite-plus": "^0.1.24"
"vite": "^8.0.0"
}
}
2 changes: 1 addition & 1 deletion examples/01-basic/11-custom-placeholder/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
/// <reference types="vite-plus/client" />
/// <reference types="vite/client" />
2 changes: 1 addition & 1 deletion examples/01-basic/11-custom-placeholder/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import react from "@vitejs/plugin-react";
import * as fs from "fs";
import * as path from "path";
import { defineConfig } from "vite-plus";
import { defineConfig } from "vite";
// https://vitejs.dev/config/
export default defineConfig(((conf: { command: string }) => ({
plugins: [react()],
Expand Down
Loading
Loading