Box operator logic by default#786
Merged
frankmcsherry merged 1 commit intoTimelyDataflow:masterfrom Apr 13, 2026
Merged
Conversation
frankmcsherry
force-pushed
the
operator_boxing
branch
from
0796d98 to
23e23ec
Compare
This was referenced Apr 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boxes operator logic by default, resulting in substantially less monomorphization in some cases (e.g. Materialize).
The
OperatorBuildertypes that help construct builders take aL: Fn<...>that is the closure that acts as the operator logic. This is specialized for each closure, which can result in a substantial amount of codegen, much of which is largely redundant. One fix to this is boxing these closures, which results in a vcall at operator scheduling time. Another fix here is to outline several complex timestamp-only methods, to avoid their "specialization" in the context of each closure.Although the
buildmethods now default to boxing, they work by way of abuild_typedmethod that retains the ability to fully specialize if the user wants this. But the default is now to box.