Skip to content

Move OutputHandleCore::cease to more general impl #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankmcsherry merged 1 commit into from
May 6, 2024
Merged

Move OutputHandleCore::cease to more general impl #563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions timely/src/dataflow/operators/generic/handles.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,11 @@ impl<'a, T: Timestamp, CB: ContainerBuilder, P: Push<Bundle<T, CB::Container>>>
assert!(cap.valid_for_output(&self.internal_buffer), "Attempted to open output session with invalid capability");
self.push_buffer.session_with_builder(cap.time())
}

/// Flushes all pending data and indicate that no more data immediately follows.
pub fn cease(&mut self) {
self.push_buffer.cease();
}
}

impl<'a, T: Timestamp, C: Container, P: Push<Bundle<T, C>>> OutputHandleCore<'a, T, CapacityContainerBuilder<C>, P> {
Expand Down Expand Up @@ -264,11 +269,6 @@ impl<'a, T: Timestamp, C: Container, P: Push<Bundle<T, C>>> OutputHandleCore<'a,
pub fn session<'b, CT: CapabilityTrait<T>>(&'b mut self, cap: &'b CT) -> Session<'b, T, CapacityContainerBuilder<C>, PushCounter<T, C, P>> where 'a: 'b {
self.session_with_builder(cap)
}

/// Flushes all pending data and indicate that no more data immediately follows.
pub fn cease(&mut self) {
self.push_buffer.cease();
}
}

impl<'a, T: Timestamp, CB: ContainerBuilder, P: Push<Bundle<T, CB::Container>>> Drop for OutputHandleCore<'a, T, CB, P> {
Expand Down