Fix #395: Add next_count returning the notification count#396
Merged
frankmcsherry merged 2 commits intoTimelyDataflow:masterfrom Jun 30, 2021
Merged
Fix #395: Add next_count returning the notification count#396frankmcsherry merged 2 commits intoTimelyDataflow:masterfrom
frankmcsherry merged 2 commits intoTimelyDataflow:masterfrom
Conversation
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
force-pushed
the
notificator_for_each_395
branch
from
bd572b5 to
89b5e56
Compare
Member
Author
|
Ok, the fix isn't correct yet, working on it! |
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
frankmcsherry
approved these changes
Jun 30, 2021
Member
frankmcsherry
left a comment
frankmcsherry
left a comment
There was a problem hiding this comment.
This looks great; thanks for noticing and fixing the issue!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #395
Signed-off-by: Moritz Hoffmann antiguru@gmail.com