Variable supports container streams#564
Merged
frankmcsherry merged 2 commits intoFeb 12, 2025
Merged
Conversation
Adds support for `Variable` for suitable container streams. By default, support vectors, but leave the possibility for others to implement the new `Negate` and `ResultsIn` extension traits, which are the required interface for `Variable`. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variable supports container streams. The PR achieves this by introducing two new extension traits:
ResultsInappliesPathSummary::results_into every record in the stream.Negatenegates the diffs in a stream.This is in support of allowing columnar data in Materialize recursive contexts.