Seal: Drop chain while feeding data to builder#482
Merged
frankmcsherry merged 1 commit intomasterfrom May 7, 2024
Merged
Conversation
Fix a regression where the columnated merge batcher would only deallocate the merged chain after revealing all data to the builder. Instead, it now drains the chain, which deallocates each chunk after revealing its contents to the builder. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
frankmcsherry
approved these changes
May 7, 2024
Member
frankmcsherry
left a comment
frankmcsherry
left a comment
There was a problem hiding this comment.
Looks good, and thank you!
antiguru
added a commit
to MaterializeInc/differential-dataflow
that referenced
this pull request
May 7, 2024
Seal: Drop chain while feeding data to builder (TimelyDataflow#482)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a regression where the columnated merge batcher would only deallocate the merged chain after revealing all data to the builder. Instead, it now drains the chain, which deallocates each chunk after revealing its contents to the builder.