Re-introduce safe consolidation#481
Merged
frankmcsherry merged 1 commit intoTimelyDataflow:masterfrom May 6, 2024
Merged
Conversation
frankmcsherry
changed the title
frankmcsherry
force-pushed
the
safe_consolidation
branch
from
b7d5d31 to
c4c7723
Compare
frankmcsherry
force-pushed
the
safe_consolidation
branch
from
c4c7723 to
ff5473b
Compare
Member
Author
|
This is substantially faster than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidation previously used an
unsafeimplementation because it improved performance overslice::split_at_mut. This no longer appears to be the case, and also unsafe code is bad and probably doesn't work.At the same time, the current consolidation also appears to be almost 2x as slow as a version from @antiguru that copies from one container to another, and perhaps the in-place consolidation results in loop-carried dependencies or something like that. There is certainly some more to look into here, especially as consolidation is such a common event.