Log size/capacity/allocations from the merge batchers#434
Merged
frankmcsherry merged 2 commits intoTimelyDataflow:masterfrom Dec 8, 2023
Merged
Log size/capacity/allocations from the merge batchers#434frankmcsherry merged 2 commits intoTimelyDataflow:masterfrom
frankmcsherry merged 2 commits intoTimelyDataflow:masterfrom
Conversation
antiguru
force-pushed
the
batcher_size_logger
branch
from
c75ea12 to
e2016ae
Compare
This logs size/capacity/allocation changes from the columnar merge batcher. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
force-pushed
the
batcher_size_logger
branch
from
e2016ae to
b7524c7
Compare
antiguru
changed the title
frankmcsherry
approved these changes
Dec 8, 2023
Member
frankmcsherry
left a comment
frankmcsherry
left a comment
There was a problem hiding this comment.
Seems good, and understandable; thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This logs records/size/capacity/allocation changes from the columnar merge batcher, and only records from the vec-based merge batcher.