trace: remove redundant bounds implied by the trait definition#363
Closed
petrosagg wants to merge 1 commit into
Closed
trace: remove redundant bounds implied by the trait definition#363petrosagg wants to merge 1 commit into
petrosagg wants to merge 1 commit into
Conversation
Many methods in DD are requiring the BatchReader and Cursor bounds on the Batch and Cursor associated types of a TraceReader respectively. However these bounds are already implied by the trait definition and can be omitted, resulting in simpler signatures. Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
petrosagg
force-pushed
the
remove-implied-bounds
branch
from
910ab28 to
1f51561
Compare
Member
|
Did Rust land some |
Contributor
Author
|
Hm, I'm not sure. I haven't tried compiling with an older rust |
Contributor
|
|
Contributor
Author
|
superseded by #367 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many methods in DD are requiring the
BatchReaderandCursorbounds on theBatchandCursorassociated types of aTraceReaderrespectively. However these bounds are already implied by the trait definition and can be omitted, resulting in simpler signatures.