Skip to content

Function for concatenating rather than replacing#288

Merged
frankmcsherry merged 2 commits intoTimelyDataflow:masterfrom
davidspies:dspies/setconcat
Nov 22, 2020
Merged

Function for concatenating rather than replacing#288
frankmcsherry merged 2 commits intoTimelyDataflow:masterfrom
davidspies:dspies/setconcat

Conversation

@davidspies
Copy link
Copy Markdown
Contributor

In the case where the variable is being accumulated by concatenating on a shrinking diff, it may be more efficient to skip the negate-and-then-un-negate part.

@frankmcsherry
Copy link
Copy Markdown
Member

Sorry for the delay.

Talking this out, this looks like the SemigroupVariable, but is perhaps appropriate for folks who don't know statically that they will have the structural guarantee it provides. If that is the intent, it would be great to put some comments in to that effect (the comments in the file could generally be improved, which is on me). In particular, it would be great to say what set_concat corresponds to (self.set(self.concat(result), I think) and why one would use it (performance).

Comment thread src/operators/iterate.rs Outdated
@frankmcsherry
Copy link
Copy Markdown
Member

Going to merge a fast-follow with some refreshed documentation (re-reading it myself it now seems very problematic).

@frankmcsherry frankmcsherry merged commit 7f97aa6 into TimelyDataflow:master Nov 22, 2020
This was referenced Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants