Skip to content

Fix IndexError on sparse vertex ids in kahns_algorithm_topo - #15088

Closed
SAY-5 wants to merge 1 commit into
TheAlgorithms:masterfrom
SAY-5:fix-kahns-topo-sparse-ids
Closed

SAY-5 wants to merge 1 commit into
TheAlgorithms:masterfrom
SAY-5:fix-kahns-topo-sparse-ids

Conversation

@SAY-5

@SAY-5 SAY-5 commented Aug 26, 2026

Copy link
Copy Markdown

Describe your change:

Fixes #15071. topological_sort used a list sized to len(graph) for indegree tracking, which assumes vertex ids are contiguous integers starting at 0. Graphs with sparse ids (e.g. {10: [20], 20: []}) crashed with IndexError. Switched indegree to a dict keyed by the actual vertex ids, and switched the queue to collections.deque so popleft() is O(1) instead of list.pop(0).

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
@SAY-5

SAY-5 commented Sep 27, 2026

Copy link
Copy Markdown
Author

Upstream already landed this in #15076, so closing this one.

@SAY-5 SAY-5 closed this Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Inefficient pop(0) queue operations and IndexError on sparse vertex IDs in graphs/kahns_algorithm_topo.py

1 participant