fix: int_to_roman silently returns wrong values for out-of-range input#14635
Open
faizzyhon wants to merge 2 commits intoTheAlgorithms:masterfrom
Open
fix: int_to_roman silently returns wrong values for out-of-range input#14635faizzyhon wants to merge 2 commits intoTheAlgorithms:masterfrom
faizzyhon wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
Added input validation for int_to_roman function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
int_to_romanperformed no input validation. Python's floor-division semantics silently corrupted results for out-of-range inputs:Root cause:
divmod(-1, 1000)returns(-1, 999)in Python, so'M' * -1yields''and the remainder999propagates through the ROMAN lookup table, producing a plausible-looking but completely wrong answer.Fix
Added early validation guards:
bool, which is a subclass ofint)Describe your change:
Checklist: