Repository navigation
Recursively delete a directory with readonly file results in inconsistent state #849
Description
Describe the bug
Recursively deleting a directory with read only file results in an inconsistent state of the MockFileSystem:
- The deletion results (as expected) in an
UnauthorizedAccessException - The file is still present (
File.Existsreturnstrue) - The directory however is removed (
Directory.Existsreturnsfalse)
To Reproduce
Consider the following unit test (using Xunit and FluentAssertions):
[Fact]
public void DeleteDirectoryRecursive_WithReadOnlyFile_ShouldThrowExceptionAndNotDeleteDirectory()
{
var sut = new MockFileSystem();
sut.Directory.CreateDirectory("foo");
sut.File.WriteAllText("foo/bar.txt", "xyz");
sut.File.SetAttributes("foo/bar.txt", FileAttributes.ReadOnly);
var exception = Record.Exception(() =>
{
sut.Directory.Delete("foo", true);
});
exception.Should().BeAssignableTo<UnauthorizedAccessException>();
sut.File.Exists("foo/bar.txt").Should().BeTrue();
sut.Directory.Exists("foo").Should().BeTrue();
}This test fails at the last line, as the directory is deleted, although the file still exists, resulting in an inconsistent state of the MockFileSystem
Expected behavior
The unit test should be successful.
Activity
fgreinacher commentedon May 18, 2022
Thanks for reporting! This would probably needs to be fixed in https://github.com/TestableIO/System.IO.Abstractions/blob/main/src/System.IO.Abstractions.TestingHelpers/MockDirectory.cs#L118.
VictorLlanir commentedon Jul 2, 2022
Hello, @fgreinacher, I would like to work on this issue.
fgreinacher commentedon Jul 3, 2022
Thanks!
VictorLlanir commentedon Jul 3, 2022
You're welcome, @fgreinacher! I've already opened a PR (#863) for this issue.
fix: consider readonly files when deleting directories (#863)
github-actions commentedon Jul 19, 2022
This is addressed in release v17.0.23.