Skip to content

FileSystemInfo.LinkTarget property is not exposed (this was added in .NET 6) #789

Closed
Closed
FileSystemInfo.LinkTarget property is not exposed (this was added in .NET 6)#789
Labels
area: coreIssues that address the core abstractions & the wrappersstate: in workIssues that are currently worked onstate: releasedIssues that are releasedtype: enhancementIssues that propose new functionality

Description

@BrianMcBrayer
BrianMcBrayer
opened on Jan 7, 2022

Describe the bug
I think (?) this is a bug because this is a property on System.IO.FileSystemInfo that is not on System.IO.Abstractions.IFileSystemInfo. This property was added in .NET 6 to help working with symlinks. See https://docs.microsoft.com/en-us/dotnet/api/system.io.filesysteminfo.linktarget?view=net-6.0

To Reproduce

  1. Look at ApiParityTests.FileIno_.NET 6.0.snap
  2. See that "System.String LinkTarget" is marked as a missing member

or

  1. Write an app that needs to access LinkTarget

Expected behavior
I would expect IFileSystemInfo to have a LinkTarget property when this package is consumed by a .NET 6 app.

Note
I will be very happy to implement this. The only question I have is how does this project handle multitargetting? Any gotchas I need to know? Otherwise I'll add it and also add tests and such. I need this for something and want to help make it happen.

Activity

  1. BrianMcBrayer
    added
    state: needs discussionIssues that need further discussion
    type: bugIssues that describe misbehaving functionality
    on Jan 7, 2022

  2. BrianMcBrayer commented on Jan 7, 2022

    @BrianMcBrayer
    BrianMcBrayer
    on Jan 7, 2022
    ContributorAuthor

    I've got the code almost ready to go. I need some guidance on adding to the test helpers--I'll put the PR up and we can discuss.

  3. fgreinacher commented on Jan 8, 2022

    @fgreinacher
    fgreinacher
    on Jan 8, 2022
    Contributor

    Thanks for bringing this up! I'll try to answer your questions in the PR!

  4. fgreinacher
    added
    area: coreIssues that address the core abstractions & the wrappers
    state: in workIssues that are currently worked on
    type: enhancementIssues that propose new functionality
    and removed
    state: needs discussionIssues that need further discussion
    type: bugIssues that describe misbehaving functionality
    on Jan 8, 2022
  5. fgreinacher
    closed this as completedin ba59ebeon Jan 11, 2022

  6. github-actions commented on Jan 11, 2022

    @github-actions
    github-actionsBot
    on Jan 11, 2022

    This is addressed in release v16.1.1.

  7. github-actions
    added
    state: releasedIssues that are released
    on Jan 11, 2022
  8. TwanVanDongen
    added a commit that references this issue on Nov 1, 2024

    feat: Add `LinkTarget` to `FileSystemInfo` for .NET 6 targets (Testab…

    ba59ebe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: coreIssues that address the core abstractions & the wrappersstate: in workIssues that are currently worked onstate: releasedIssues that are releasedtype: enhancementIssues that propose new functionality

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions