perf: compute NODE_ENV up-front & flip opt-in#6445
Draft
43081j wants to merge 1 commit into
Draft
Conversation
The code published to npm still contains the `NODE_ENV` guards. If you're running this code in an env where that isn't set, or where it is `production`, you pay the cost _per call_ of the string comparison. We can avoid that by computing it up front since the env won't change. Then we instead have `if (IS_DEV)` rather than `if (process.env.NODE_ENV === ...)`. Additionally, many of these guards were previously on `=== 'development'`. This meant only something like vite in dev mode would see useful errors (since most other tools won't set NODE_ENV at all). If we flip this around to `!== 'production'`, it means all dev runtimes would get the more useful error messages.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code published to npm still contains the
NODE_ENVguards. If you're running this code in an env where that isn't set, or where it isproduction, you pay the cost per call of the string comparison.We can avoid that by computing it up front since the env won't change.
Then we instead have
if (IS_DEV)rather thanif (process.env.NODE_ENV === ...).Additionally, many of these guards were previously on
=== 'development'. This meant only something like vite in dev mode would see useful errors (since most other tools won't set NODE_ENV at all). If we flip this around to!== 'production', it means all dev runtimes would get the more useful error messages.DRAFT until we agree that its ok to flip the flag
✅ Checklist
pnpm test:pr.