test(angular-query/query-options): add type tests for 'getQueryState' and 'skipToken' inference - #11465
Open
sukvvon wants to merge 1 commit into
Open
test(angular-query/query-options): add type tests for 'getQueryState' and 'skipToken' inference#11465sukvvon wants to merge 1 commit into
sukvvon wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe Angular type-test suite adds assertions for tagged query state and ChangesAngular query type coverage
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change expands Angular query-option type coverage without changing runtime behavior or published implementation. No current merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 73612c4
☁️ Nx Cloud last updated this comment at |
Contributor
size-limit report 📦
|
Contributor
🚀 Changeset Version Preview2 package(s) bumped directly, 23 bumped as dependents. 🟨 Minor bumps
🟩 Patch bumps
|
… and 'skipToken' inference
sukvvon
force-pushed
the
test/angular-query-options-test-d-parity
branch
from
September 10, 2026 01:28
cb54331 to
73612c4
Compare
sukvvon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
angular-query-experimental'squery-options.test-d.tswas missing three cases thatreact-query,preact-query,solid-queryandsvelte-queryalready cover in theirqueryOptionstype tests. This ports them over.should return the proper type when passed to getQueryState— asserts the tagged query key narrowsstate?.datatonumber | undefined. Placed right after the existinggetQueryDatacase, matching where the other adapters put it.should infer even if there is a conditional skipToken— aqueryFnthat is eitherskipTokenor a real function still infersnumber | undefined.should infer to unknown if we disable a query with just a skipToken— aqueryFnthat is onlyskipTokeninfersunknown.Each one was checked by changing the input rather than the expected type: flipping the
queryFnresult type (or replacingskipTokenwith a real function) makes the corresponding assertion fail, so all three react to what they claim to test.Type tests only — no runtime or published code is touched.
✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit