docs(philosophy): clarify 'Three.js framework adapters' to 'Three.js renderers' - #2251
docs(philosophy): clarify 'Three.js framework adapters' to 'Three.js renderers'#2251kushaim wants to merge 1 commit into
Conversation
…renderers' In the 'Controlled is Cool' section, the bullet on Non-DOM support said 'Three.js framework adapters'. Three.js is not a framework - it's a WebGL rendering library. The intended meaning was that TanStack Form's controlled-component approach works with non-DOM renderers, including Three.js. Replaced 'framework adapters' with 'renderers' to be accurate.
📝 WalkthroughWalkthroughThe philosophy documentation rewords the “Non-DOM support” bullet to describe Three.js renderers instead of Three.js framework adapters. ChangesDocumentation update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Clarifies documentation wording in the “Controlled is Cool” section to more accurately describe Three.js usage as a renderer context (non-DOM render targets), aligning the phrasing with Three.js’s role as a rendering library.
Changes:
- Replaced “Three.js framework adapters” with “Three.js renderers” in the Non-DOM support bullet.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Three.js framework adapters → Three.js renderers. Three.js is a WebGL renderer, not a framework, and the surrounding sentence uses
enderer for everything else.