Skip to content

Don't evict query keys from cache#903

Closed
kevin-dp wants to merge 6 commits into
mainfrom
kevin/do-not-evict-query-keys-from-cache
Closed

Don't evict query keys from cache#903
kevin-dp wants to merge 6 commits into
mainfrom
kevin/do-not-evict-query-keys-from-cache

Conversation

@kevin-dp

@kevin-dp kevin-dp commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

When a live query is GCed its subscription is unsubscribed and the Query collection then immediately tells tanstack/query to remove the corresponding query keys. However, this means that the query data is immediately GCed. So if a user quickly browses to another page and comes back the data has to load again because it was immediately GCed on onmount. We should not evict it immediately but simply delete the tanstack/query observer such that tanstack/query will GC the data after the cache time has elapsed.

#870 fixes this but it also introduces a couple of other changes that may not be needed. I removed the commits from that PR to see if we can fix this problem more surgically.

github-actions Bot and others added 4 commits November 25, 2025 08:28
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fix: remove auto-merge from docs PR in release workflow

The docs generation CI job after releases was failing because it tried to immediately merge the PR, but tests need to run first. Now the workflow just creates the PR and lets it go through normal CI checks before manual merge.

Co-authored-by: Claude <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Nov 25, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fd7eb11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Nov 25, 2025

Copy link
Copy Markdown
More templates

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@903

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@903

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@903

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@903

@tanstack/offline-transactions

npm i https://pkg.pr.new/@tanstack/offline-transactions@903

@tanstack/powersync-db-collection

npm i https://pkg.pr.new/@tanstack/powersync-db-collection@903

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@903

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@903

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@903

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@903

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@903

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@903

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@903

commit: f632eef

@github-actions

github-actions Bot commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 86.3 kB

ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/collection/change-events.js 1.38 kB
./packages/db/dist/esm/collection/changes.js 977 B
./packages/db/dist/esm/collection/events.js 388 B
./packages/db/dist/esm/collection/index.js 3.24 kB
./packages/db/dist/esm/collection/indexes.js 1.1 kB
./packages/db/dist/esm/collection/lifecycle.js 1.67 kB
./packages/db/dist/esm/collection/mutations.js 2.26 kB
./packages/db/dist/esm/collection/state.js 3.43 kB
./packages/db/dist/esm/collection/subscription.js 2.48 kB
./packages/db/dist/esm/collection/sync.js 2.37 kB
./packages/db/dist/esm/deferred.js 207 B
./packages/db/dist/esm/errors.js 4.19 kB
./packages/db/dist/esm/event-emitter.js 748 B
./packages/db/dist/esm/index.js 2.64 kB
./packages/db/dist/esm/indexes/auto-index.js 742 B
./packages/db/dist/esm/indexes/base-index.js 766 B
./packages/db/dist/esm/indexes/btree-index.js 1.87 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.1 kB
./packages/db/dist/esm/indexes/reverse-index.js 513 B
./packages/db/dist/esm/local-only.js 837 B
./packages/db/dist/esm/local-storage.js 2.1 kB
./packages/db/dist/esm/optimistic-action.js 359 B
./packages/db/dist/esm/paced-mutations.js 496 B
./packages/db/dist/esm/proxy.js 3.22 kB
./packages/db/dist/esm/query/builder/functions.js 733 B
./packages/db/dist/esm/query/builder/index.js 3.96 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 917 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.35 kB
./packages/db/dist/esm/query/compiler/expressions.js 430 B
./packages/db/dist/esm/query/compiler/group-by.js 1.8 kB
./packages/db/dist/esm/query/compiler/index.js 1.96 kB
./packages/db/dist/esm/query/compiler/joins.js 2 kB
./packages/db/dist/esm/query/compiler/order-by.js 1.25 kB
./packages/db/dist/esm/query/compiler/select.js 1.07 kB
./packages/db/dist/esm/query/expression-helpers.js 1.43 kB
./packages/db/dist/esm/query/ir.js 673 B
./packages/db/dist/esm/query/live-query-collection.js 360 B
./packages/db/dist/esm/query/live/collection-config-builder.js 5.26 kB
./packages/db/dist/esm/query/live/collection-registry.js 264 B
./packages/db/dist/esm/query/live/collection-subscriber.js 1.74 kB
./packages/db/dist/esm/query/live/internal.js 130 B
./packages/db/dist/esm/query/optimizer.js 2.56 kB
./packages/db/dist/esm/query/predicate-utils.js 2.88 kB
./packages/db/dist/esm/query/subset-dedupe.js 921 B
./packages/db/dist/esm/scheduler.js 1.21 kB
./packages/db/dist/esm/SortedMap.js 1.18 kB
./packages/db/dist/esm/strategies/debounceStrategy.js 247 B
./packages/db/dist/esm/strategies/queueStrategy.js 428 B
./packages/db/dist/esm/strategies/throttleStrategy.js 246 B
./packages/db/dist/esm/transactions.js 2.9 kB
./packages/db/dist/esm/utils.js 881 B
./packages/db/dist/esm/utils/browser-polyfills.js 304 B
./packages/db/dist/esm/utils/btree.js 5.61 kB
./packages/db/dist/esm/utils/comparison.js 852 B
./packages/db/dist/esm/utils/index-optimization.js 1.51 kB
./packages/db/dist/esm/utils/type-guards.js 157 B

compressed-size-action::db-package-size

@github-actions

github-actions Bot commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 3.34 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 225 B
./packages/react-db/dist/esm/useLiveInfiniteQuery.js 1.17 kB
./packages/react-db/dist/esm/useLiveQuery.js 1.11 kB
./packages/react-db/dist/esm/useLiveSuspenseQuery.js 431 B
./packages/react-db/dist/esm/usePacedMutations.js 401 B

compressed-size-action::react-db-package-size

@kevin-dp
kevin-dp force-pushed the kevin/do-not-evict-query-keys-from-cache branch 2 times, most recently from d926e09 to a358d7a Compare November 25, 2025 11:00
@kevin-dp
kevin-dp force-pushed the kevin/do-not-evict-query-keys-from-cache branch from a358d7a to f632eef Compare November 25, 2025 11:12
@kevin-dp

Copy link
Copy Markdown
Contributor Author

Closed in favor of #905

@kevin-dp kevin-dp closed this Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants