Skip to content

fix(licensing): call the paid plan Pro, as the site and server now do - #3989

Merged
datlechin merged 2 commits into
mainfrom
fix/rename-starter-to-pro
Nov 2, 2026
Merged

datlechin merged 2 commits into
mainfrom
fix/rename-starter-to-pro

Conversation

@datlechin

Copy link
Copy Markdown
Member

Summary

  • The macOS app now names the paid plan Pro, as the pricing page and license server do: the plan badge, the License settings plan headers and plan line, the Data Rewind upgrade alert and the Data Rewind settings note.
  • The plan code stays starter in code, license payloads and on the server. Device counts still come from the server.
  • The string catalog gains the two new Data Rewind keys with all six translations (plan names stay English), drops the three keys no code uses any more, and marks Pro as in use again.
  • The iOS app shows no plan name, so it does not change.

Test plan

  • LicenseTierTests/starterTierIsShownAsPro() (new) asserts the starter tier displays as Pro and Team as Team.
  • LicensePresentationTests/recurringPlanStatesBoth() and planWithoutCycle() pinned "Starter" on purpose and now expect "Pro".
  • verify.sh: build PASS, test LicenseTierTests LicensePresentationTests PASS (53 of 53), lint PASS, l10n PASS.

The plan code stays starter in license payloads and on the server; only the name the app shows changes. The catalog drops the three keys no code uses any more.
@datlechin
datlechin enabled auto-merge (squash) November 2, 2026 13:31
@datlechin
datlechin merged commit 48f4e03 into main Nov 2, 2026
9 checks passed
datlechin added a commit that referenced this pull request Nov 2, 2026
Brings main's 43 commits, among them the Pro plan name (#3989), column
masking (#3978) and the SSH host name hardening (GHSA-94m6-qx4g-cpwg).

- LicenseTier, LicensePresentationTests, LicenseTierTests: stay deleted, since
  accounts replace license keys; the next commit renames the plan in
  AccountCodes instead.
- ProFeature: keeps paidPlanRequirement; main changed only a comment on
  requiredTier, which this branch dropped.
- TeamLibraryModels and its tests: stay deleted with /v1. The refused SSH host
  check main added to sanitized() now guards TeamLibraryChange.connection,
  and its test moves to TeamLibrarySyncTests.
- MainEditorContentView: the Query Insights refresh main added reads
  FeatureAccess, not LicenseManager.
- project.yml: the app links main's TableProInfluxDBCore and
  TableProQdrantCore; TableProAnalytics stays out.
- Localizable.xcstrings: merged key by key; no key changed on both sides.
datlechin added a commit that referenced this pull request Nov 2, 2026
…16.6)

AccountCodes names the starter code Pro, the name main gave the plan in
#3989; entitlements still carry the code starter. The catalog's Pro key,
which main already translates for every language, covers it, and the
Starter key left with the merge.
datlechin added a commit that referenced this pull request Nov 2, 2026
* fix(security): tier SQL with one classifier for macOS and iOS

Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-7WQZ7IBV.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-85FM8CNF.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-BO7086MJ.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-DXB5GXHF.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-RSL7CZQC.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-TUTSEW23.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-VEO0AP8A.
Advisory: GHSA-3x6q-h487-r38w

* fix(linux-grid): stop column moves at the row numbers, keep the focus in view and announce them (#3985)

* feat(linux-sidebar): list functions, procedures, sequences and triggers (#3969)

Co-authored-by: Ngo Quoc Dat <datlechin@gmail.com>

* feat(plugin-influxdb): add an InfluxDB 2 and 3 driver over HTTP (#3976)

Co-authored-by: Ngo Quoc Dat <datlechin@gmail.com>

* feat(plugin-qdrant): add a Qdrant driver over the REST API (#3972)

Co-authored-by: Ngo Quoc Dat <datlechin@gmail.com>

* feat(display-format): decode Protobuf schemas and Schema Registry values (#3979)

Co-authored-by: Ngo Quoc Dat <datlechin@gmail.com>

* refactor(core): move the Linux core crates into a shared core workspace (#3986)

* fix(security): import TableProSQLGrammar where the Flux classifier reads its tiers

* docs(core): record the bindings, grid data, plugin ABI and SQL Server decisions (#3987)

* fix(licensing): call the paid plan Pro, as the site and server now do (#3989)

* fix(parsing): stop malformed replies and files from crashing, hanging or filling memory (#3991)

---------

Co-authored-by: Nguyễn Nam Long <j2teamnnl@gmail.com>
datlechin added a commit that referenced this pull request Nov 2, 2026
* fix(security): tier SQL with one classifier for macOS and iOS

Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-7WQZ7IBV.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-85FM8CNF.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-BO7086MJ.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-DXB5GXHF.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-RSL7CZQC.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-TUTSEW23.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-VEO0AP8A.
Advisory: GHSA-3x6q-h487-r38w

* fix(security): run external statements as approved and read only in the engine

Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-AK0DTFEV.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-2N5FN7X4.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-A6ENWH1O.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-AWAVHFV6.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-DRI3Z3MD.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-G0F69IT6.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-KIUNV39X.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-KYD5T4TJ.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-LG65P706.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-P5IW81B3.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-PCUF2R3V.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-UHVIMOF0.
Advisory: GHSA-3xf7-86qj-4546

* fix(l10n): add the iOS strings the MongoDB and ClickHouse refusals use

* fix(linux-clickhouse): hold user SQL and read-only connections to readonly=1

readonly=2 still let INSERT INTO FUNCTION file() write a file on the server (measured on 26.8).

Advisory: GHSA-3xf7-86qj-4546

* feat(plugin-influxdb): add an InfluxDB 2 and 3 driver over HTTP (#3976)

Co-authored-by: Ngo Quoc Dat <datlechin@gmail.com>

* feat(plugin-qdrant): add a Qdrant driver over the REST API (#3972)

Co-authored-by: Ngo Quoc Dat <datlechin@gmail.com>

* feat(display-format): decode Protobuf schemas and Schema Registry values (#3979)

Co-authored-by: Ngo Quoc Dat <datlechin@gmail.com>

* refactor(core): move the Linux core crates into a shared core workspace (#3986)

* fix(security): import TableProSQLGrammar where the Flux classifier reads its tiers

* fix(security): import TableProSQLGrammar where the gates read the shared classifier's tier

* docs(core): record the bindings, grid data, plugin ABI and SQL Server decisions (#3987)

* fix(licensing): call the paid plan Pro, as the site and server now do (#3989)

* fix(parsing): stop malformed replies and files from crashing, hanging or filling memory (#3991)

---------

Co-authored-by: Nguyễn Nam Long <j2teamnnl@gmail.com>
@datlechin
datlechin deleted the fix/rename-starter-to-pro branch November 2, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant