Open
Conversation
| if [ -n "$2" ] && [ "${2:0:1}" != "-" ] && [ "${2:0:3}" == "gpt" ]; then | ||
| if [ -n "$2" ] && [ "${2:0:1}" != "-" ]; then | ||
| if [ "${api_service}" = "openai" ] && [ "${2:0:3}" != "gpt" ]; then | ||
| echo "Error: --model requires a gpt model" |
Author
There was a problem hiding this comment.
I was following the convention of the previous error message
echo "Error: --model requires a gpt model"
or am I missing something else?
Contributor
There was a problem hiding this comment.
Ah sorry, nevermind.
Contributor
There was a problem hiding this comment.
Of course you are right. I'm just getting started with work today ;-)
Contributor
|
Could you also please sign your commit? |
Author
|
of course! please forgive the force push |
|
@Dadams2 I know it’s been a while, but you’ll also need to sign off your commit. If you are still interested in getting this merged, you can easily achieve that by running git rebase -i origin/main --signoffThe conflicts also need to be resolved, of course. |
Signed-off-by: David Adams <david@dadams2.com>
Author
|
@ghost91- Have done! |
Contributor
|
One question about that - you can already set the url manually. Why do we still need the ollama option? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the bare minimum changes. It might be reasonable to also include in the documentation:
-m llama3.1I think it is somewhat safe to assume that if a user knows they want ollama they will want to specify a model themselves. This assumption is why I have omitted setting more defaults.