Skip to content

fix(utils): harden package for stable release - #2365

Merged
dancormier merged 1 commit into
mainfrom
STACKS-890/stabilize-utils
Aug 12, 2026
Merged

fix(utils): harden package for stable release#2365
dancormier merged 1 commit into
mainfrom
STACKS-890/stabilize-utils

Conversation

@dancormier

Copy link
Copy Markdown
Contributor

Summary

  • validate the packed Stacks Utils package through a clean ESM and TypeScript NodeNext consumer
  • fix NodeNext declaration resolution and isolate the custom Day.js locale from consumer applications
  • document formatting/runtime contracts and add timezone-safe boundary coverage
  • run the package smoke test in CI

Jira

Validation

  • npm run build -w packages/stacks-utils
  • npm run test -w packages/stacks-utils — 22 passed
  • npm run lint -w packages/stacks-utils
  • npm run test:package -w packages/stacks-utils
  • npm run build -w packages/stacks-svelte
  • npm run lint -w packages/stacks-svelte
  • npm run test -w packages/stacks-svelte — 577 browser tests and 26 tooling tests passed
  • independent Day.js locale-mutation check
  • git diff --check

Release notes

  • includes a patch changeset for @stackoverflow/stacks-utils
  • this is release-readiness work; stable publication remains part of the global Changesets prerelease exit after the remaining Stacks packages are ready

Accessibility

  • no UI or accessibility behavior changed

@changeset-bot

changeset-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ed32260

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stackoverflow/stacks-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Aug 12, 2026

Copy link
Copy Markdown

Deploy Preview for stackoverflow-email ready!

Name Link
🔨 Latest commit ed32260
🔍 Latest deploy log https://app.netlify.com/projects/stackoverflow-email/deploys/6a7cbc0dd11b37000881ce18
😎 Deploy Preview https://deploy-preview-2365--stackoverflow-email.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Aug 12, 2026

Copy link
Copy Markdown

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit ed32260
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/6a7cbc0db34b9e0008e25963
😎 Deploy Preview https://deploy-preview-2365--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@dancormier
dancormier marked this pull request as ready for review August 12, 2026 18:50
@dancormier
dancormier requested a review from a team as a code owner August 12, 2026 18:50
@dancormier

dancormier commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Note

This PR is part of a larger effort to close out the beta phase of this repository.


Automated review

Findings

No actionable findings. I found no meaningful consumer-visible output or API regressions.

The removed Day.js threshold and rounding settings were previously added through updateLocale, but Day.js only reads those settings when passed to dayjs.extend(relativeTime, options). They were therefore already ineffective. Relative-time strings and effective boundary behavior remain unchanged.

The change improves compatibility by:

  • Preserving existing formatTime output.
  • Preventing mutation of the consumer’s default English Day.js locale.
  • Fixing NodeNext declaration resolution without changing exports.
  • Retaining existing ESM runtime imports.

Review summary

  • Standards findings: 0
  • Spec findings: 0
  • Observed checks: All GitHub CI checks passed. The utils unit, build, and packed-package tests also completed successfully during verification.
  • Residual risk: Importing the package still globally installs Day.js’s relativeTime plugin and registers the stacks-utils locale. Plugin installation predates this PR; locale-name collision is theoretically possible but unlikely.
  • Deferred Jira work: Stable publication, dist-tag correction, and Svelte’s stable dependency remain explicitly deferred to the global release process.

@dancormier
dancormier enabled auto-merge (squash) August 12, 2026 18:55
@dancormier
dancormier disabled auto-merge August 12, 2026 18:55
@dancormier
dancormier merged commit 4b94e3d into main Aug 12, 2026
25 checks passed
@dancormier
dancormier deleted the STACKS-890/stabilize-utils branch August 12, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant