chore(input): fix non text input styles - #2088
Conversation
🦋 Changeset detectedLatest commit: 0b3aac6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
giamir
left a comment
There was a problem hiding this comment.
This fixes the issue. I am not familiar enough with input stylesheet to comment on the exact rule. I find the nested input a bit odd honestly. It feels like it should be a separate component but it was already there so I guess it is fair to leave it for now.
Other design system don't call that an input and we should probably follow their lead
https://open-ui.org/components/combobox.research/
Anyway that's a topic for a separate ticket potentially. :)
Thanks @mukunku
Summary
This PR fixes a bug I introduced in #2070 which breaks the non-text type inputs styles by pushing the date picker etc to the left: https://beta.svelte.stackoverflow.design/?path=/docs/components-textinput--docs

How to Test