Skip to content

chore(input): fix non text input styles - #2088

Merged
mukunku merged 3 commits into
betafrom
sal/fix-input-types
Dec 3, 2025
Merged

chore(input): fix non text input styles#2088
mukunku merged 3 commits into
betafrom
sal/fix-input-types

Conversation

@mukunku

@mukunku mukunku commented Dec 3, 2025

Copy link
Copy Markdown
Collaborator

Summary

This PR fixes a bug I introduced in #2070 which breaks the non-text type inputs styles by pushing the date picker etc to the left: https://beta.svelte.stackoverflow.design/?path=/docs/components-textinput--docs

How to Test

@changeset-bot

changeset-bot Bot commented Dec 3, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b3aac6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Dec 3, 2025

Copy link
Copy Markdown

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 0b3aac6
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/693065c35fce56000878aba7
😎 Deploy Preview https://deploy-preview-2088--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Dec 3, 2025

Copy link
Copy Markdown

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit 0b3aac6
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/693065c3045a5a0008fef3b0
😎 Deploy Preview https://deploy-preview-2088--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mukunku
mukunku marked this pull request as ready for review December 3, 2025 16:54

@giamir giamir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue. I am not familiar enough with input stylesheet to comment on the exact rule. I find the nested input a bit odd honestly. It feels like it should be a separate component but it was already there so I guess it is fair to leave it for now.

Other design system don't call that an input and we should probably follow their lead
https://open-ui.org/components/combobox.research/

Anyway that's a topic for a separate ticket potentially. :)

Thanks @mukunku

@mukunku
mukunku merged commit 2f3cb89 into beta Dec 3, 2025
18 checks passed
@mukunku
mukunku deleted the sal/fix-input-types branch December 3, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants