chore(navigation): move transition to NavigationItem - #2074
Merged
Conversation
🦋 Changeset detectedLatest commit: 2bb2afe The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dancormier
marked this pull request as ready for review
November 25, 2025 23:33
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
giamir
approved these changes
Nov 26, 2025
giamir
left a comment
giamir
left a comment
Contributor
There was a problem hiding this comment.
I took the liberty to make the transition an opt in feature. That helps also with odd behavior I noticed in the trailing example where animations where triggered also when elements were selected.
Good to merge and release for me so that @kylejrp can use it.
Thank you both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
transition:slideto theNavigationItemcomponent. This will allow for simpler markup for toggling Navigation sections and increases the likelihood that markup will be valid.See this Slack thread for more details. cc @kylejrp
Note
@giamir Should we consider adding a prop to add/remove the transition? I'm not sure what the potential unintended effects of including the transition on every
NavigationItemmight be.