chore(activity-indicator): rm HC overrides - #2066
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 9d56811 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dancormier
marked this pull request as ready for review
November 24, 2025 16:50
Collaborator
|
Not totally related to activity indicator and probably only an issue in the docs but the G in the avatar example goes dark when in Dark HC mode (it's fine in Light HC mode) |
CGuindon
approved these changes
Nov 24, 2025
CGuindon
left a comment
CGuindon
left a comment
Collaborator
There was a problem hiding this comment.
Activity indicator LGTM
giamir
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all the HC overrides for the Activity Indicator component. A11Y tests pass, so I think we're no longer need the overrides.
How to review
Code changes
All code changes are localized to activity-indicator.less so that should be all the code you need to look at. All other changes are visual regression images being regenerated.
Visual changes
Screenshots
Before
After