Update TextInput.svelte to not emit a self-closing tag on the <input> element - #2064
Closed
kylejrp wants to merge 1 commit into
Closed
Update TextInput.svelte to not emit a self-closing tag on the <input> element#2064kylejrp wants to merge 1 commit into
<input> element#2064kylejrp wants to merge 1 commit into
Conversation
|
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 73844d6 |
👷 Deploy request for stacks-svelte pending review.Visit the deploys page to approve it
|
mukunku
approved these changes
Nov 25, 2025
mukunku
self-requested a review
November 25, 2025 17:13
mukunku
requested changes
Nov 25, 2025
Collaborator
There was a problem hiding this comment.
After deeper investigation, unfortunately this breaks linting because prettier requires self terminating elements and this can't be changed: prettier/prettier#5641
mukunku
added a commit
that referenced
this pull request
Dec 2, 2025
* shine changes in classic * svelte updates * a11y tweak * remove webkit overrides for testing * fix lint * Create lemon-coins-chew.md * add back zoom webkit fix * implement #2064 into v3 * Revert "implement #2064 into v3" This reverts commit 5850d2a. * remove webkit override again * consistent heights * update baseline * adjust nested inputs heights * baseline * Input tweaks (#2073) * Various input sizing, layout, docs tweaks * Fix sm, lg w-axis padding * update baseline * update figma link * PR feedback * fix tests --------- Co-authored-by: Dan Cormier <dcormier@stackoverflow.com>
mukunku
added a commit
that referenced
this pull request
Dec 3, 2025
* shine changes in classic * svelte updates * a11y tweak * remove webkit overrides for testing * fix lint * Create lemon-coins-chew.md * add back zoom webkit fix * implement #2064 into v3 * Revert "implement #2064 into v3" This reverts commit 5850d2a. * remove webkit override again * consistent heights * update baseline * adjust nested inputs heights * baseline * Various input sizing, layout, docs tweaks * Input tweaks (#2073) * Various input sizing, layout, docs tweaks * Fix sm, lg w-axis padding * stacks classic and docs updates * update baseline * create textarea svelte component * update figma link * set figma and svelte links * Create afraid-cheetahs-fetch.md * expose textarea component * lint * PR feedback * fix tests * fix min-height * add *new* label in navigation * add accessibility section * remove `optiona`l props per pr feedback * remove superfluous wrapper div * make min-height textarea specific * lint * fix tests * remove all usages of flex--item * set initial height of text area --------- Co-authored-by: Dan Cormier <dancormierall@gmail.com> Co-authored-by: Dan Cormier <dcormier@stackoverflow.com>
mukunku
added a commit
that referenced
this pull request
Dec 3, 2025
* shine changes in classic * svelte updates * a11y tweak * remove webkit overrides for testing * fix lint * Create lemon-coins-chew.md * add back zoom webkit fix * implement #2064 into v3 * Revert "implement #2064 into v3" This reverts commit 5850d2a. * remove webkit override again * consistent heights * update baseline * adjust nested inputs heights * baseline * Various input sizing, layout, docs tweaks * Input tweaks (#2073) * Various input sizing, layout, docs tweaks * Fix sm, lg w-axis padding * stacks classic and docs updates * update baseline * create textarea svelte component * update figma link * set figma and svelte links * Create afraid-cheetahs-fetch.md * expose textarea component * lint * PR feedback * fix tests * fix min-height * add *new* label in navigation * add accessibility section * remove `optiona`l props per pr feedback * remove superfluous wrapper div * make min-height textarea specific * lint * fix tests * remove all usages of flex--item * upgrade textinput & textarea to Svelte 5 style * lint * fix lint * Create dirty-snails-obey.md * upgrade migration guide * fix textarea tests * re-lint * move snippet type declarations to the top * lint --------- Co-authored-by: Dan Cormier <dancormierall@gmail.com> Co-authored-by: Dan Cormier <dcormier@stackoverflow.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was running some output from a Svelte component that used
<TextInput/>through W3C's HTML validator and got this informational message:It links to this guidance:
https://github.com/validator/validator/wiki/Markup-%C2%BB-Void-elements#trailing-slashes-in-void-element-start-tags-do-not-mark-the-start-tags-as-self-closing
TL;DR: it does nothing so we shouldn't emit it
It doesn't bother me too much personally, but it does check off a validation box 🤷