-
Notifications
You must be signed in to change notification settings - Fork 104
chore(menu): update to SHINE styles #2046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
7475b64
chore(menu): update to SHINE styles
dancormier a410479
Minor related popover style tweaks
dancormier 4bb57d9
Add svelte menu component
dancormier 923a512
Update a11y tests
dancormier e751adb
Update migration guide
dancormier 87705b0
Update visual test (just the test file)
dancormier 6f9b955
add changeset
dancormier a83f8cc
formatting
dancormier 743314f
linting
dancormier bfc8a44
Update menu components outside of menu
dancormier 359b739
Add Svelte and Figma links in frontmatter
dancormier b364354
Eating dogfood (popover in menu story)
dancormier 356ebcc
Remove MenuItemControl
dancormier 787d6f8
Rename MenuItemLink to MenuItem
dancormier 970fa6b
Rename MenuItem input
dancormier 51cdac2
Rename s-menu--link to s-menu--action
dancormier f4aa2d8
Improve selected, radio, checkbox styles
dancormier 14a6c1b
Stick to `ul`, remove `iconTitle`
dancormier 32e3619
Simplify tests; add i18nSelectedLabel; cleanup
dancormier 7b44768
Update migration guide
dancormier b3097e3
add comment for selected checkmark
dancormier 6ede6fb
Merge branch 'beta' into SPARK-71/menu
dancormier 47225d2
Let's just put that comment inline
dancormier 8c4c113
fix checkmark background image
dancormier f0eff98
proper indentation!
dancormier 1c910f0
Improve custom checkmark styling
dancormier a1f1aca
Final cleanup
dancormier 27e1da8
Merge branch 'beta' into SPARK-71/menu
dancormier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@stackoverflow/stacks": minor | ||
| "@stackoverflow/stacks-svelte": minor | ||
| --- | ||
|
|
||
| Update Menu to SHINE styles; add Svelte component |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.