Skip to content

fix(tags): add screen reader improvements - #2045

Merged
dancormier merged 11 commits into
betafrom
sal/SPARK-109
Nov 19, 2025
Merged

fix(tags): add screen reader improvements#2045
dancormier merged 11 commits into
betafrom
sal/SPARK-109

Conversation

@mukunku

@mukunku mukunku commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

Summary

This PR addresses some accessibility gaps with regards to our Tags component and screen readers: https://stackoverflow.atlassian.net/browse/A11Y-89

It does the following:

  • Makes sure tags are tabbable by appending tabindex when using <span>s instead of <a>s
  • Make sure we have screen reader text for the dismiss button in our documentation
  • Add screen reader text for the four different tag states: ignored, watched, moderator, required

How to Test

Confirm screen reader improvements in:

@changeset-bot

changeset-bot Bot commented Nov 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2525502

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Nov 12, 2025

Copy link
Copy Markdown

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 2525502
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/691b6e320ab61500086d459b
😎 Deploy Preview https://deploy-preview-2045--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 12, 2025

Copy link
Copy Markdown

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit 2525502
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/691b6e32e7052e00085222c8
😎 Deploy Preview https://deploy-preview-2045--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mukunku
mukunku marked this pull request as ready for review November 12, 2025 20:29

@dancormier dancormier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling these accessibility improvements @mukunku ❤️ I'm 100% on board for the watched/ignored/etc updates and the addition of descriptive text for the dismiss button.

The only real reservation I have is the addition of tabindex="0" to tags that aren't interactive. Screen readers should be able to generally assist with informing the user of static text and should prioritize tabbing for interactive elements. Generally, I reserve it for either elements that are scrollable (like the code examples in the docs) or elements that are not interactive by default but made interactive via JS (this should almost always be avoided but exceptions occasionally arise).

Let me know if this makes sense or not, or if I'm misinterpreting the purpose

Comment thread packages/stacks-docs/product/components/tags.html Outdated
Comment thread packages/stacks-docs/product/components/tags.html
Comment thread packages/stacks-docs/product/components/tags.html Outdated
@dancormier dancormier changed the title accessibility(tags): add screen reader improvements fix(tags): add screen reader improvements Nov 17, 2025
@mukunku
mukunku requested a review from dancormier November 17, 2025 18:40

@dancormier dancormier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukunku! :shipit:

@dancormier
dancormier merged commit 10e108a into beta Nov 19, 2025
18 checks passed
@dancormier
dancormier deleted the sal/SPARK-109 branch November 19, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants