Skip to content

feat(br): Update border radius atomic styles - #2026

Merged
ttaylor-stack merged 14 commits into
betafrom
spark-91/border-radius-atomic-styles
Oct 31, 2025
Merged

feat(br): Update border radius atomic styles#2026
ttaylor-stack merged 14 commits into
betafrom
spark-91/border-radius-atomic-styles

Conversation

@ttaylor-stack

@ttaylor-stack ttaylor-stack commented Oct 29, 2025

Copy link
Copy Markdown
Collaborator

Update border radius atomic styles as specified in the SPARK-91.

Ticket: https://stackoverflow.atlassian.net/browse/SPARK-91

Figma: https://www.figma.com/design/do4Ug0Yws8xCfRjHe9cJfZ/Project-SHINE---Product-UI?node-id=2213-7342&p=f&t=czT0zuZbbghSpKgs-0

Notes:

  • Anywhere in the docs that used bar-sm or bar-lg I replaced with bar-md
  • I left the base atomic styles that are used by the other components in place e.g. br-sm and br-md. I thought because it's used in so many components it makes sense to update them within the components story instead of this one.

@changeset-bot

changeset-bot Bot commented Oct 29, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c8b61d3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Oct 29, 2025

Copy link
Copy Markdown

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit c8b61d3
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/6904b838af84a800087f899e
😎 Deploy Preview https://deploy-preview-2026--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 29, 2025

Copy link
Copy Markdown

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit c8b61d3
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/6904b838641f9200086eda72
😎 Deploy Preview https://deploy-preview-2026--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ttaylor-stack
ttaylor-stack marked this pull request as ready for review October 29, 2025 15:03
@ttaylor-stack ttaylor-stack changed the title Update border radius atomic styles feat(br): Update border radius atomic styles Oct 29, 2025

@dancormier dancormier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this on @ttaylor-stack ❤️

The tl;dr for my review is that we should get rid of all references of sm and lg border radius classes and custom properties. This extends to the custom property references in .less files across the code base.

Warning

Removing/replacing styles is likely to introduce merge conflicts for any in-flight component changes. I don't expect them to be tough to handle, but I figured it warrants a heads up.

Comment thread packages/stacks-classic/lib/atomic/border.less
Comment thread packages/stacks-classic/lib/exports/constants-helpers.less Outdated
Comment thread packages/stacks-docs/_data/borders.json
@CGuindon

Copy link
Copy Markdown
Collaborator

I'm still seeing all the sm and lg classes in the documentation — does the preview need to be re-generated?
Screenshot 2025-10-29 at 12 57 58 PM

@dancormier dancormier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For breaking changes, we should mention the breaks in the Migration Guide (example here). I think something general mentioning the removal of sm/lg border should be sufficient.

Besides that I think this is all set. We'll probably want to wait until the Avatar PR is merged before we merge this one, but we're close!

🙂 Thanks @ttaylor-stack

@ttaylor-stack
ttaylor-stack enabled auto-merge (squash) October 31, 2025 12:00
@ttaylor-stack
ttaylor-stack merged commit 2a4a741 into beta Oct 31, 2025
18 checks passed
@ttaylor-stack
ttaylor-stack deleted the spark-91/border-radius-atomic-styles branch October 31, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants