feat(br): Update border radius atomic styles - #2026
Conversation
🦋 Changeset detectedLatest commit: c8b61d3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
….com/StackExchange/Stacks into spark-91/border-radius-atomic-styles
dancormier
left a comment
There was a problem hiding this comment.
Thank you for taking this on @ttaylor-stack ❤️
The tl;dr for my review is that we should get rid of all references of sm and lg border radius classes and custom properties. This extends to the custom property references in .less files across the code base.
Warning
Removing/replacing styles is likely to introduce merge conflicts for any in-flight component changes. I don't expect them to be tough to handle, but I figured it warrants a heads up.
dancormier
left a comment
There was a problem hiding this comment.
For breaking changes, we should mention the breaks in the Migration Guide (example here). I think something general mentioning the removal of sm/lg border should be sufficient.
Besides that I think this is all set. We'll probably want to wait until the Avatar PR is merged before we merge this one, but we're close!
🙂 Thanks @ttaylor-stack

Update border radius atomic styles as specified in the SPARK-91.
Ticket: https://stackoverflow.atlassian.net/browse/SPARK-91
Figma: https://www.figma.com/design/do4Ug0Yws8xCfRjHe9cJfZ/Project-SHINE---Product-UI?node-id=2213-7342&p=f&t=czT0zuZbbghSpKgs-0
Notes:
bar-smorbar-lgI replaced withbar-mdbr-smandbr-md. I thought because it's used in so many components it makes sense to update them within the components story instead of this one.