Fix admin organization users emails filter query parameter serialization (fix #3541) - #1
Open
SparshGarg999 wants to merge 1 commit into
Open
SparshGarg999 wants to merge 1 commit into
SparshGarg999 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes openai#3541
Summary
The
users.listendpoint insrc/openai/resources/admin/organization/users/users.pyreceivesemails: SequenceNotStr[str]. The SDK query serializer formats array values usingemails[]=valuebrackets, whereas the API expects scalar or comma-separatedemails=valueparameters.This PR updates
emailsparameter transformation inUserListParamsto ensure email filters are properly formatted as scalar/repeatable query parameters.How was this tested?