-
Notifications
You must be signed in to change notification settings - Fork 2
docs: finalize chore_dashboard_regen_quoted_pr_false_positive after PR #253 #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SoundMindsAI
merged 1 commit into
main
from
docs/finalize-chore-dashboard-regen-quoted-pr-false-positive
May 25, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
...es/2026_05_25_chore_dashboard_regen_quoted_pr_false_positive/pipeline_status.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # Pipeline Status — chore_dashboard_regen_quoted_pr_false_positive | ||
|
|
||
| ## Idea | ||
| - Status: Complete | ||
| - File: idea.md | ||
| - /idea-preflight verdict (2026-05-25): Ready after 3-edit patch (line 572→581 drift, PR-TBD→PR #221 for sibling chore, "Why deferred" status clarification) | ||
|
|
||
| ## Spec | ||
| - Status: Approved | ||
| - Date: 2026-05-25 | ||
| - File: feature_spec.md | ||
| - Cross-model review: GPT-5.5 converged after 3 cycles | ||
| - Cycle 1: 1 Low finding (AC-7 missed single-line triple-backtick fences) — accepted, added AC-12 | ||
| - Cycle 2: 2 Low findings (regex hint `+` would skip empty spans; 4 stale "6 tests" residuals) — both accepted, patched | ||
| - Cycle 3: 0 findings → stop rule satisfied | ||
| - Phases: 1 (single phase, two-PR rollout — see §3 Phase boundaries) | ||
| - FRs: 5 (FR-1 helper, FR-2 wire-in, FR-3 test class, FR-4 docstring, FR-5 post-merge finalization) | ||
| - ACs: 7 (AC-6 through AC-12) | ||
|
|
||
| ## Plan | ||
| - Status: Approved | ||
| - Date: 2026-05-25 | ||
| - File: implementation_plan.md | ||
| - Cross-model review: GPT-5.5 cycle 1 produced 2 findings (1 Low, 1 Medium); both accepted and patched (gate arithmetic 6→7; regex `\`{3,}` for spec-compliance with "3-or-more" fence delimiter). Cycle 2 = 0 findings → stop rule satisfied. | ||
| - Stories: 5 total across 2 epics (Epic 1 = Stories 1.1–1.4 in PR A; Epic 2 = Story 2.1 in PR B) | ||
| - Phases covered: single phase (two-PR rollout per spec §3) | ||
|
|
||
| ## Implementation | ||
| - Status: Complete | ||
| - Date: 2026-05-25 | ||
| - PR A (content): [#253](https://github.com/SoundMindsAI/relyloop/pull/253) — merged 2026-05-25T21:53:09Z as squash `20bcb36d` | ||
| - Stories completed: 4 (1.1 helper, 1.2 wire-in, 1.3 test class, 1.4 docstring) + Epic 1 phase-gate fix | ||
| - Tests: 8 in TestBacktickStripPriority3 (AC-6..AC-13); 36 total in test_dashboard_pr_extraction.py; 1434+ in full backend unit suite | ||
| - CI: 6/7 green; 1 pre-existing failure (`smoke (operator-path tutorial flow)` — captured in `bug_smoke_dashboard_demo_state_locator_missing`; same as PR #250) | ||
| - Cross-model reviews: | ||
| - spec-gen: 3 GPT-5.5 cycles converged | ||
| - impl-plan-gen: 2 GPT-5.5 cycles converged | ||
| - Epic 1 phase-gate: 1 Medium finding (naive `{3,}` regex would miss 4-backtick outer with inner 3-backtick) → accepted, backref `(`{3,}).*?\1` + new AC-13 test | ||
| - Final review: 1 Medium finding (self-triggering spec/plan examples + remaining priority-4 false positive) → accepted in part (spec/plan rewritten); priority-4 deferred as follow-on chore [`chore_dashboard_regen_priority4_dependency_cite_false_positive`](../chore_dashboard_regen_priority4_dependency_cite_false_positive/idea.md) | ||
| - Gemini Code Assist: 1 High finding (double-backtick inline spans missed by Pass-B regex) → accepted, fix shipped in `5b595bc9` using Gemini's suggested backref `(`{1,2})[^\n]*?\1` | ||
| - PR B (finalization): in flight — this branch (`docs/finalize-chore-dashboard-regen-quoted-pr-false-positive`) | ||
|
|
||
| ## Done | ||
| - Status: Pending (PR B merge) | ||
| - Folder moved to `docs/00_overview/implemented_features/2026_05_25_chore_dashboard_regen_quoted_pr_false_positive/` via FR-5 in this PR B. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 0 additions & 29 deletions
29
...nned_features/chore_dashboard_regen_quoted_pr_false_positive/pipeline_status.md
This file was deleted.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a minor markdown formatting issue on lines 24, 38, and 40. Escaping backticks with backslashes inside single backticks (e.g.,
\{3,}`) is not standard markdown and can lead to rendering issues or display literal backslashes.To cleanly display literal backticks inside inline code blocks, you can wrap the entire inline code block in double backticks (
Here is how they can be formatted:
regex ``{3,} `` `backref `` ({3,}).*?\1 `` `backref `` ({1,2})[^\n]*?\1 `` `