[bug] Pinching to zoom on Android fails occasionally

When on an Android device, the two-finger pinch action to zoom produces an inconsistent behaviour, often not zooming on the page.

It happens both inside and outside of sortable components.

No need to provide a JSBin, as it's happening on the demo page.

To Reproduce
Steps to reproduce the behavior:

Go to https://sortablejs.github.io/Sortable/ on Chrome in an Android device
Perform a two-finger pinch to zoom anywhere on the page.
Page doesn't get zoomed occasionally.

Expected behavior

Page should always get zoomed.

Information

Tested on a Huawei P20 Pro, Android 10, Chrome version 84

It has to do with this touchmove event. I'll see what I can do :S

Sortable/src/Sortable.js

Lines 2021 to 2028 in d53f85e

    
           // Fixed #973: 
        
           if (documentExists) { 
        
             on(document, "touchmove", function (evt) { 
        
               if ((Sortable.active || awaitingDragStarted) && evt.cancelable) { 
        
                 evt.preventDefault(); 
        
               } 
        
             }); 
        
           }

@aquaductape

I own a GalaxyA21s using Firefox 79.0.5 and it works fine on my device.

@aquaductape I'm pretty sure that Sortable.active will be null because no sortables are being dragged, so no defaults will be prevented on a zoom in.

@rsmarques

@rsmarques Is this on all websites using Sortable, or just the Sortable site?

It occurs on all websites when using Android Chrome. When i remove sortablejs on my project, I'm able to zoom consistently again on Android Chrome.

@waynevanson

@waynevanson as @aquaductape stated, it happens in every website on Android Chrome which uses SortableJS

This is still a problem. I recently got rid of JQuery Sortable, and now users are complaing that their gesture doesn't work anymore.

Navigation Menu

Repository navigation

[bug] Pinching to zoom on Android fails occasionally #1888

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// Fixed #973:
	if (documentExists) {
	on(document, "touchmove", function (evt) {
	if ((Sortable.active \|\| awaitingDragStarted) && evt.cancelable) {
	evt.preventDefault();
	}
	});
	}

[bug] Pinching to zoom on Android fails occasionally #1888

Description

Activity

aquaductape commented on Aug 24, 2020

waynevanson commented on Aug 31, 2020

waynevanson commented on Aug 31, 2020

aquaductape commented on Aug 31, 2020

rsmarques commented on Sep 1, 2020

Earlopain commented on Jan 27, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions