SONARJAVA-6528 S2068, S6418, and S6437: Make use of common secret exclusion filter

[pierre-loup-tristant-sonarsource]

Part of SONARJAVA-6528

[hashicorp-vault-sonar-prod]

SONARJAVA-6528

[gitar-bot]

💡 Quality: Typos in new test-fixture comments

A few of the newly added/modified explanatory comments contain typos:

• HardCodedPasswordCheckCustom.java:20 and :28 both read // Compliant, , short value filter with a doubled comma.
• HardCodedPasswordCheckSample.java:226 uses a triple-slash /// instead of // (myA.setProperty("password", "xxxxx"); /// Compliant, short value filter).

These are harmless to the check semantics (comments only) but worth cleaning up for consistency with the surrounding fixtures. Fix by removing the extra comma and the extra slash respectively.

_{Was this helpful? React with 👍 / 👎}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[gitar-bot]

CI failed: The PR causes test failures in the `java-checks-aws` module, specifically in `HardCodedCredentialsShouldNotBeUsedCheckTest`, due to a discrepancy between the expected and actual number of detected security issues.

Overview

Multiple CI jobs failed consistently during the test execution phase of the java-checks-aws module. The analysis reveals a regression in HardCodedCredentialsShouldNotBeUsedCheckTest triggered by the recent changes to secret exclusion filtering.

Failures

Test Regression in HardCodedCredentialsShouldNotBeUsedCheckTest (confidence: high)

• Type: test
• Affected jobs: 84801679890, 84811299911, 85014637765, 84801224806
• Related to change: yes
• Root cause: The refactoring of secret exclusion logic led to a change in the number of issues detected by HardCodedCredentialsShouldNotBeUsedCheck. The test expects 47 issues but now reports 55, indicating that the new logic is either more sensitive than expected or correctly identifying previously missed violations.
• Suggested fix: Review the 8 additional issues identified by the check in HardCodedCredentialsShouldNotBeUsedCheckSample.java. If these are correct findings under the new logic, update the test expectations (issue markers) in the sample file to match the new count.

Summary

• Change-related failures: 1 (Test regression in java-checks-aws following secret filter refactor).
• Infrastructure/flaky failures: 0
• Recommended action: The developer should examine the surefire-reports for java-checks-aws, verify if the 8 additional issues are intended behavior, and update the test case expectations accordingly.

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Refactors S2068, S6418, and S6437 to utilize the common secret exclusion filter. Address minor typos identified in the new test-fixture comments to finalize the implementation.

💡 Quality: Typos in new test-fixture comments

📄 java-checks-test-sources/default/src/main/java/checks/HardCodedPasswordCheckCustom.java:20 📄 java-checks-test-sources/default/src/main/java/checks/HardCodedPasswordCheckCustom.java:28 📄 java-checks-test-sources/default/src/main/java/checks/HardCodedPasswordCheckSample.java:226 📄 java-checks-test-sources/aws/src/main/java/checks/security/HardCodedCredentialsShouldNotBeUsedCheckSample.java:146

A few of the newly added/modified explanatory comments contain typos:

• HardCodedPasswordCheckCustom.java:20 and :28 both read // Compliant, , short value filter with a doubled comma.
• HardCodedPasswordCheckSample.java:226 uses a triple-slash /// instead of // (myA.setProperty("password", "xxxxx"); /// Compliant, short value filter).

These are harmless to the check semantics (comments only) but worth cleaning up for consistency with the surrounding fixtures. Fix by removing the extra comma and the extra slash respectively.

🤖 Prompt for agents

Code Review: Refactors S2068, S6418, and S6437 to utilize the common secret exclusion filter. Address minor typos identified in the new test-fixture comments to finalize the implementation.

1. 💡 Quality: Typos in new test-fixture comments
   Files: java-checks-test-sources/default/src/main/java/checks/HardCodedPasswordCheckCustom.java:20, java-checks-test-sources/default/src/main/java/checks/HardCodedPasswordCheckCustom.java:28, java-checks-test-sources/default/src/main/java/checks/HardCodedPasswordCheckSample.java:226, java-checks-test-sources/aws/src/main/java/checks/security/HardCodedCredentialsShouldNotBeUsedCheckSample.java:146

   A few of the newly added/modified explanatory comments contain typos:
   - `HardCodedPasswordCheckCustom.java:20` and `:28` both read `// Compliant, , short value filter` with a doubled comma.
   - `HardCodedPasswordCheckSample.java:226` uses a triple-slash `///` instead of `//` (`myA.setProperty("password", "xxxxx"); /// Compliant, short value filter`).
   
   These are harmless to the check semantics (comments only) but worth cleaning up for consistency with the surrounding fixtures. Fix by removing the extra comma and the extra slash respectively.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}