Fix: Empty CLI string defaults no longer override env/API config#17
Merged
Merged
Conversation
Douglas (dacoburn)
approved these changes
Dec 31, 2025
When CLI arguments with empty string defaults (like --dockerfiles) are not explicitly provided by the user, they were incorrectly overwriting non-empty values loaded from environment variables or the Socket Basics API config. The issue was that the check `if arg_value is not None` passed for empty strings, causing `config_dict['dockerfiles'] = ""` to wipe out the value from the dashboard config. Changed the condition to `if arg_value` (truthy check) for non-bool types, so empty string defaults don't override actual config values. This fixes Dockerfile scanning not working when configured via the Socket dashboard, as the `dockerfiles` value was being cleared by the CLI default.
120c0cd to
678368f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if arg_value is not Nonetoif arg_valuefor non-bool typesProblem
When CLI arguments with empty string defaults (like
--dockerfiles) are not explicitly provided by the user, they were overwriting non-empty values from:INPUT_DOCKERFILESset via GitHub Actions workflow)This caused Dockerfile scanning to fail even when correctly configured in the dashboard with
dockerfiles: "Dockerfile", because the CLI default of""would wipe out that value.Root Cause
Fix
Test plan
dockerfiles: "Dockerfile"value