Repository navigation
Count only side by side collections in MaxSingleQueryCollections - #44
Merged
Merged
Conversation
A single query joins every collection it loads, but only collections side by side multiply each other's rows. A collection nested in another returns a row per item of the inner one, so a chain of nested collections now counts as one, and a collection holding several side by side counts as many as it holds. Bump to 0.8.0.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single query joins every collection it loads, but only collections side by side multiply each other's rows. A collection nested in another returns a row per item of the inner one, so it is not a cartesian explosion.
MaxSingleQueryCollectionsnow counts that way:Include(_ => _.Departments).ThenInclude(_ => _.Employees)was 2, and is now 1.Include(_ => _.Tasks).Include(_ => _.Department.Employees)is 2.Includes and projected collections are combined into one tree by path, so an Include under a projected collection is nested in it.
Found from a GraphQL query loading a group's users and each user's groups, which was logged as 2 collections though it returns one row per membership.
MultipleCollectionIncludeWarning