Do not pass T.untyped to ObjectSpace::WeakMap

[LTe]

Motivation

In sorbet/sorbet#6610 type_member changed from out to fixed: T.untyped. From this point we should not pass explicit T.untyped as argument to generic type.

Implementation

There is no need to special case for ObjectSpace::WeakMap anymore.

Tests

I added specs

[Morriar]

Very nice!

I wonder if we could add two tests under spec/tapioca/cli/gem_spec where we install different versions of Sorbet and check the output.

Something like this:

        it "generates `ObjectSpace::WeakMap` as a generic type with Sorbet < X.Y.Z" do
          foo = mock_gem("foo", "0.0.1") do
            write("lib/foo.rb", <<~RB)
              Foo = ObjectSpace::WeakMap.new
            RB
          end
          @project.require_mock_gem(foo)
          @project.require_real_gem("sorbet-static", "X.Y.Z")
          @project.bundle_install
          result = @project.tapioca("gem")
          assert_project_file_equal("sorbet/rbi/gems/foo@0.0.1.rbi", <<~RBI)
             Foo = T.let(T.unsafe(nil), ObjectSpace::WeakMap[T.untyped])
          RBI
        end

        it "generates `ObjectSpace::WeakMap` as a non-generic type with Sorbet >= X.Y.Z" do
          foo = mock_gem("foo", "0.0.1") do
            write("lib/foo.rb", <<~RB)
              Foo = ObjectSpace::WeakMap.new
            RB
          end
          @project.require_mock_gem(foo)
          @project.require_real_gem("sorbet-static", "X.Y.Z")
          @project.bundle_install
          result = @project.tapioca("gem")
          assert_project_file_equal("sorbet/rbi/gems/foo@0.0.1.rbi", <<~RBI)
             Foo = T.let(T.unsafe(nil), ObjectSpace::WeakMap)
          RBI
        end

[KaanOzkan]

Thanks a lot for the PR and the prompt back and forth.

[Morriar]

Thank you for adding the other test 🙏

[paracycle]

Thank you! The work in this PR is very much appreciated. ❤️