Migrate workspace symbol to use Rubydex#4019
Merged
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom Mar 26, 2026
Merged
Migrate workspace symbol to use Rubydex#4019vinistock merged 1 commit intorubydex_adoption_feature_branchfrom
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom
Conversation
vinistock
added
server
19 tasks
vinistock
force-pushed
the
03-19-migrate_workspace_symbol_to_rubydex
branch
from
b182366 to
23fc40e
Compare
vinistock
force-pushed
the
03-03-migrate_go_to_definition_to_use_rubydex
branch
from
005200d to
f3b0fcc
Compare
st0012
approved these changes
Mar 20, 2026
vinistock
force-pushed
the
03-03-migrate_go_to_definition_to_use_rubydex
branch
from
f3b0fcc to
97436ad
Compare
vinistock
force-pushed
the
03-19-migrate_workspace_symbol_to_rubydex
branch
from
23fc40e to
2ef74aa
Compare
vinistock
force-pushed
the
03-03-migrate_go_to_definition_to_use_rubydex
branch
from
97436ad to
ffe9281
Compare
Base automatically changed from
03-03-migrate_go_to_definition_to_use_rubydex
to
rubydex_adoption_feature_branch
March 26, 2026 18:01
vinistock
force-pushed
the
03-19-migrate_workspace_symbol_to_rubydex
branch
from
2ef74aa to
0333da1
Compare
vinistock
merged commit 2837bc0
into
rubydex_adoption_feature_branch
52 of 53 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR migrates workspace symbol to use Rubydex.
Implementation
Graph#searchto match symbolsvisibilityas a new field in workspace symbols. I think excluding based on visibility was not the right choice, so I removed that filterto_lsp_kindto our definition patchesAutomated Tests
I removed a redundant test and expanded the one about private/protected definitions.