Switch singleton class names to new style#3993
Merged
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom Mar 19, 2026
Merged
Conversation
vinistock
added
breaking-change
st0012
approved these changes
Mar 6, 2026
vinistock
force-pushed
the
03-03-start_indexing_and_resolving_rubydex_graph
branch
from
d3fa68d to
c7cf7ea
Compare
vinistock
force-pushed
the
03-05-switch_singleton_class_names_to_new_style
branch
from
e6ed0b9 to
d27b55e
Compare
19 tasks
vinistock
force-pushed
the
03-03-start_indexing_and_resolving_rubydex_graph
branch
from
c7cf7ea to
de5e731
Compare
vinistock
force-pushed
the
03-05-switch_singleton_class_names_to_new_style
branch
from
d27b55e to
e50b099
Compare
vinistock
force-pushed
the
03-03-start_indexing_and_resolving_rubydex_graph
branch
from
de5e731 to
e0a1f4a
Compare
vinistock
force-pushed
the
03-05-switch_singleton_class_names_to_new_style
branch
from
e50b099 to
abf5c41
Compare
alexcrocha
approved these changes
Mar 18, 2026
Base automatically changed from
03-03-start_indexing_and_resolving_rubydex_graph
to
rubydex_adoption_feature_branch
March 19, 2026 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Ruby LSP indexer currently represents singleton class names as
Foo::<Class:Foo>, but Rubydex uses the shorterFoo::<Foo>.A lot of places in the code build names with that convention, so it's not possible to migrate requests one by one while maintaining the current functionality without changing the representation first.
Implementation
This PR just changes all singleton names and logic to use the new names.