Skip to content

Fix send_log_message ignoring type parameter #3969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 20, 2026
Merged

Fix send_log_message ignoring type parameter #3969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ruby_lsp/base_server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def send_empty_response(id)

#: (String message, ?type: Integer) -> void
def send_log_message(message, type: Constant::MessageType::LOG)
send_message(Notification.window_log_message(message, type: Constant::MessageType::LOG))
send_message(Notification.window_log_message(message, type: type))
end
end
end
15 changes: 15 additions & 0 deletions test/server_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,21 @@ def test_backtrace_is_printed_to_stderr_on_exceptions
end
end

def test_send_log_message_passes_type_parameter
@server.expects(:workspace_dependencies).raises(StandardError, "boom")

capture_io do
@server.process_message({
id: 1,
method: "rubyLsp/workspace/dependencies",
params: {},
})
end

log = find_message(RubyLsp::Notification, "window/logMessage")
assert_equal(RubyLsp::Constant::MessageType::ERROR, log.params.type)
end

def test_changed_file_only_indexes_ruby
path = File.join(Dir.pwd, "lib", "foo.rb")
File.write(path, "class Foo\nend")
Expand Down